Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672489 > unrolled thread

[PATCH 1/2] hpsa: limit transfer length to 1MB

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] hpsa: limit transfer length to 1MB Yadan Fan <ydfan@suse.com> - 2017-06-22 12:10 +0200
    [PATCH 2/2] smartpqi: limit transfer length to 1MB Yadan Fan <ydfan@suse.com> - 2017-06-22 12:10 +0200

#1672489 — [PATCH 1/2] hpsa: limit transfer length to 1MB

The hpsa firmware will bypass the cache for any request larger
than 1MB, so we should cap the request size to avoid any
performance degradation in SLE12-SP2.

This degradation is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
which changed max_sectors_kb to 1280k, but the hardware is able to
work fine with it, so the true fix should be from hpsa driver.

References: bsc#1025461

Signed-off-by: Yadan Fan <ydfan@suse.com>
---
 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 73daace478cb..b4c0bbea680c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -952,7 +952,7 @@ static struct scsi_host_template hpsa_driver_template = {
 #endif
 	.sdev_attrs = hpsa_sdev_attrs,
 	.shost_attrs = hpsa_shost_attrs,
-	.max_sectors = 8192,
+	.max_sectors = 1024,
 	.no_write_same = 1,
 };
 
-- 
2.12.3

[toc] | [next] | [standalone]

#1672493 — [PATCH 2/2] smartpqi: limit transfer length to 1MB

The smartpqi firmware will bypass the cache for any request larger
than 1MB, so we should cap the request size to avoid any
performance degradation on SLE12-SP2

This degradation is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
which changed max_sectors_kb to 1280k, but the hardware is able to
work fine with it, so the true fix should be from smartpqi driver.

Reference: bsc#1025461

Signed-off-by: Yadan Fan <ydfan@suse.com>
---
 drivers/scsi/smartpqi/smartpqi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h
index b673825f46b5..9513357bd472 100644
--- a/drivers/scsi/smartpqi/smartpqi.h
+++ b/drivers/scsi/smartpqi/smartpqi.h
@@ -630,7 +630,7 @@ struct pqi_encryption_info {
 };
 
 #define PQI_MAX_OUTSTANDING_REQUESTS	((u32)~0)
-#define PQI_MAX_TRANSFER_SIZE		(4 * 1024U * 1024U)
+#define PQI_MAX_TRANSFER_SIZE		(1024U * 1024U)
 
 #define RAID_MAP_MAX_ENTRIES		1024
 
-- 
2.12.3

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web