Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670398 > unrolled thread

Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij <linus.walleij@linaro.org> - 2017-06-20 10:20 +0200
    Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-20 11:00 +0200
      Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij <linus.walleij@linaro.org> - 2017-06-20 13:40 +0200
        Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-21 08:40 +0200
          Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-06-23 22:10 +0200
            Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 12:00 +0200
              Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-29 13:50 +0200
              Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 17:00 +0200
                Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij <linus.walleij@linaro.org> - 2017-06-30 00:20 +0200
                  [PULL] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-07-03 09:30 +0200
                    Re: [PULL] serial/gpio: exar: Fixes and support for IOT2000 Linus Walleij <linus.walleij@linaro.org> - 2017-07-03 10:20 +0200

#1670398 — Re: [PATCH v6 00/10] serial/gpio: exar: Fixes and support for IOT2000

On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

> This makes the gpio-exar driver usable, which was prevented by a number
> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
> series, so I'm also cross-posting to the serial and gpio lists.
>
> Changes in v6:

I merged some of the patches, that applied. Let's see if they survive
in linux-next, else I guess we need to fix this in the -rcs or for the next
kernel cycle.

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1670456

On 2017-06-20 10:19, Linus Walleij wrote:
> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> This makes the gpio-exar driver usable, which was prevented by a number
>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>> series, so I'm also cross-posting to the serial and gpio lists.
>>
>> Changes in v6:
> 
> I merged some of the patches, that applied. Let's see if they survive
> in linux-next, else I guess we need to fix this in the -rcs or for the next
> kernel cycle.

Weird that things did not apply. I just did a cherry-pick for all those
10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
know which baseline is needed, and I will rebase.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [next] | [standalone]

#1670694

On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-06-20 10:19, Linus Walleij wrote:
>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>
>>> This makes the gpio-exar driver usable, which was prevented by a number
>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>>> series, so I'm also cross-posting to the serial and gpio lists.
>>>
>>> Changes in v6:
>>
>> I merged some of the patches, that applied. Let's see if they survive
>> in linux-next, else I guess we need to fix this in the -rcs or for the next
>> kernel cycle.
>
> Weird that things did not apply. I just did a cherry-pick for all those
> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
> know which baseline is needed, and I will rebase.

This was on the "devel" branch of my GPIO tree:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1671400

On 2017-06-20 13:38, Linus Walleij wrote:
> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-06-20 10:19, Linus Walleij wrote:
>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>
>>>> This makes the gpio-exar driver usable, which was prevented by a number
>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>>>> series, so I'm also cross-posting to the serial and gpio lists.
>>>>
>>>> Changes in v6:
>>>
>>> I merged some of the patches, that applied. Let's see if they survive
>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
>>> kernel cycle.
>>
>> Weird that things did not apply. I just did a cherry-pick for all those
>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
>> know which baseline is needed, and I will rebase.
> 
> This was on the "devel" branch of my GPIO tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel

Again, all (missing) patches applied absolutely cleanly for me, see

http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [next] | [standalone]

#1673811

On 2017-06-21 08:29, Jan Kiszka wrote:
> On 2017-06-20 13:38, Linus Walleij wrote:
>> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> On 2017-06-20 10:19, Linus Walleij wrote:
>>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>
>>>>> This makes the gpio-exar driver usable, which was prevented by a number
>>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>>>>> series, so I'm also cross-posting to the serial and gpio lists.
>>>>>
>>>>> Changes in v6:
>>>>
>>>> I merged some of the patches, that applied. Let's see if they survive
>>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
>>>> kernel cycle.
>>>
>>> Weird that things did not apply. I just did a cherry-pick for all those
>>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
>>> know which baseline is needed, and I will rebase.
>>
>> This was on the "devel" branch of my GPIO tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
> 
> Again, all (missing) patches applied absolutely cleanly for me, see
> 
> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000

I've rebased over devel and noticed along this that you will have to
include "serial: uapi: Add support for bus termination" from Greg's
tty-next for the last patch to avoid breaking the build. Result pushed to

http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000

If you want me to resend anything, just let me know. Would be great to
have the remaining pieces lined up in time for the next merge window.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [next] | [standalone]

#1677577

On Fri, Jun 23, 2017 at 10:09 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-06-21 08:29, Jan Kiszka wrote:
>> On 2017-06-20 13:38, Linus Walleij wrote:
>>> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>> On 2017-06-20 10:19, Linus Walleij wrote:
>>>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>>
>>>>>> This makes the gpio-exar driver usable, which was prevented by a number
>>>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>>>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>>>>>> series, so I'm also cross-posting to the serial and gpio lists.
>>>>>>
>>>>>> Changes in v6:
>>>>>
>>>>> I merged some of the patches, that applied. Let's see if they survive
>>>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
>>>>> kernel cycle.
>>>>
>>>> Weird that things did not apply. I just did a cherry-pick for all those
>>>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
>>>> know which baseline is needed, and I will rebase.
>>>
>>> This was on the "devel" branch of my GPIO tree:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
>>
>> Again, all (missing) patches applied absolutely cleanly for me, see
>>
>> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
>
> I've rebased over devel and noticed along this that you will have to
> include "serial: uapi: Add support for bus termination" from Greg's
> tty-next for the last patch to avoid breaking the build. Result pushed to
>
> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
>
> If you want me to resend anything, just let me know. Would be great to
> have the remaining pieces lined up in time for the next merge window.

I could just pull it in, but then I want a clear indication that Greg and
say Andy are happy with this.

The serial patches are missing Gregs explicit ACK and the platform
patch could use Andy's ACK. The last patch adding the
IOT2040 is so obviously out of my GPIO territory that I want
Greg 100% aligned with this.

I am sorry that it is troublesome when things cross subsystem
boundaries, I already stretched it a bit with the things I queued
up because it annoys me too, but this is the process we have :/

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1677641

On Thu, Jun 29, 2017 at 12:51 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Fri, Jun 23, 2017 at 10:09 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-06-21 08:29, Jan Kiszka wrote:

>> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
>>
>> If you want me to resend anything, just let me know. Would be great to
>> have the remaining pieces lined up in time for the next merge window.
>
> I could just pull it in, but then I want a clear indication that Greg and
> say Andy are happy with this.

All patches that have my tag already are good from my point of view.
The rest, i.e.
"platform: Accept const properties", needs a slightly more attention.

This one on one hand does the right thing, though I would like to hear
Mika on this.

We still have platform_device_info and mfd_cell that doesn't define
the properties with const.
(I believe they should, though is it matter of this patch?)

P.S. I have looked at the current state of the use of the API in
question and rather agree with the patch, thus

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1677839

On Thu, Jun 29, 2017 at 11:51:08AM +0200, Linus Walleij wrote:
> On Fri, Jun 23, 2017 at 10:09 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > On 2017-06-21 08:29, Jan Kiszka wrote:
> >> On 2017-06-20 13:38, Linus Walleij wrote:
> >>> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >>>> On 2017-06-20 10:19, Linus Walleij wrote:
> >>>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >>>>>
> >>>>>> This makes the gpio-exar driver usable, which was prevented by a number
> >>>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
> >>>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
> >>>>>> series, so I'm also cross-posting to the serial and gpio lists.
> >>>>>>
> >>>>>> Changes in v6:
> >>>>>
> >>>>> I merged some of the patches, that applied. Let's see if they survive
> >>>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
> >>>>> kernel cycle.
> >>>>
> >>>> Weird that things did not apply. I just did a cherry-pick for all those
> >>>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
> >>>> know which baseline is needed, and I will rebase.
> >>>
> >>> This was on the "devel" branch of my GPIO tree:
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
> >>
> >> Again, all (missing) patches applied absolutely cleanly for me, see
> >>
> >> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
> >
> > I've rebased over devel and noticed along this that you will have to
> > include "serial: uapi: Add support for bus termination" from Greg's
> > tty-next for the last patch to avoid breaking the build. Result pushed to
> >
> > http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
> >
> > If you want me to resend anything, just let me know. Would be great to
> > have the remaining pieces lined up in time for the next merge window.
> 
> I could just pull it in, but then I want a clear indication that Greg and
> say Andy are happy with this.
> 
> The serial patches are missing Gregs explicit ACK and the platform
> patch could use Andy's ACK. The last patch adding the
> IOT2040 is so obviously out of my GPIO territory that I want
> Greg 100% aligned with this.
> 
> I am sorry that it is troublesome when things cross subsystem
> boundaries, I already stretched it a bit with the things I queued
> up because it annoys me too, but this is the process we have :/

I've added my acks to the serial patches, so all should be fine for you
to take this all through your tree now.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1678240

On Thu, Jun 29, 2017 at 4:49 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Jun 29, 2017 at 11:51:08AM +0200, Linus Walleij wrote:
>> On Fri, Jun 23, 2017 at 10:09 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> > On 2017-06-21 08:29, Jan Kiszka wrote:
>> >> On 2017-06-20 13:38, Linus Walleij wrote:
>> >>> On Tue, Jun 20, 2017 at 10:54 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> >>>> On 2017-06-20 10:19, Linus Walleij wrote:
>> >>>>> On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> >>>>>
>> >>>>>> This makes the gpio-exar driver usable, which was prevented by a number
>> >>>>>> of fatal bugs, and adds support for the SIMATIC IOT2040 to the 8250-exar
>> >>>>>> driver and, indirectly, to gpio-exar as well. It's a cross-subsystem
>> >>>>>> series, so I'm also cross-posting to the serial and gpio lists.
>> >>>>>>
>> >>>>>> Changes in v6:
>> >>>>>
>> >>>>> I merged some of the patches, that applied. Let's see if they survive
>> >>>>> in linux-next, else I guess we need to fix this in the -rcs or for the next
>> >>>>> kernel cycle.
>> >>>>
>> >>>> Weird that things did not apply. I just did a cherry-pick for all those
>> >>>> 10 patches on top of 5c996b7eb52c, and that went smoothly. Please let me
>> >>>> know which baseline is needed, and I will rebase.
>> >>>
>> >>> This was on the "devel" branch of my GPIO tree:
>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
>> >>
>> >> Again, all (missing) patches applied absolutely cleanly for me, see
>> >>
>> >> http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
>> >
>> > I've rebased over devel and noticed along this that you will have to
>> > include "serial: uapi: Add support for bus termination" from Greg's
>> > tty-next for the last patch to avoid breaking the build. Result pushed to
>> >
>> > http://git.kiszka.org/?p=linux.git;a=shortlog;h=refs/heads/queues/gpio-iot2000
>> >
>> > If you want me to resend anything, just let me know. Would be great to
>> > have the remaining pieces lined up in time for the next merge window.
>>
>> I could just pull it in, but then I want a clear indication that Greg and
>> say Andy are happy with this.
>>
>> The serial patches are missing Gregs explicit ACK and the platform
>> patch could use Andy's ACK. The last patch adding the
>> IOT2040 is so obviously out of my GPIO territory that I want
>> Greg 100% aligned with this.
>>
>> I am sorry that it is troublesome when things cross subsystem
>> boundaries, I already stretched it a bit with the things I queued
>> up because it annoys me too, but this is the process we have :/
>
> I've added my acks to the serial patches, so all should be fine for you
> to take this all through your tree now.

Awesome, Jan can you:

- Collect the ACKs

- Send me a pull request based on my devel branch?

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1679697 — [PULL] serial/gpio: exar: Fixes and support for IOT2000

The following changes since commit 85bb4646f8908eb786dfa19a6bb2ff1423dc8aa4:

  gpio: rcar: Add R8A7743 (RZ/G1M) support (2017-06-29 14:22:38 +0200)

are available in the git repository at:

  git://git.kiszka.org/linux.git queues/gpio-iot2000

for you to fetch changes up to 413058df4331ce29f9934a5870d582c7e71fe15f:

  serial: exar: Add support for IOT2040 device (2017-07-03 08:33:20 +0200)

This corresponds to v6 of the series with additional review and ack
tags.

----------------------------------------------------------------
Jan Kiszka (8):
      serial: uapi: Add support for bus termination
      gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards
      gpio: exar: Fix iomap request
      gpio-exar/8250-exar: Rearrange gpiochip parenthood
      serial: exar: Factor out platform hooks
      platform: Accept const properties
      gpio-exar/8250-exar: Make set of exported GPIOs configurable
      serial: exar: Add support for IOT2040 device

 drivers/base/platform.c             |   2 +-
 drivers/gpio/gpio-exar.c            |  71 +++++++--------
 drivers/tty/serial/8250/8250_exar.c | 170 +++++++++++++++++++++++++++++++++++-
 include/linux/platform_device.h     |   2 +-
 include/uapi/linux/serial.h         |   3 +
 5 files changed, 208 insertions(+), 40 deletions(-)

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [next] | [standalone]

#1679743 — Re: [PULL] serial/gpio: exar: Fixes and support for IOT2000

On Mon, Jul 3, 2017 at 9:21 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

> The following changes since commit 85bb4646f8908eb786dfa19a6bb2ff1423dc8aa4:
>
>   gpio: rcar: Add R8A7743 (RZ/G1M) support (2017-06-29 14:22:38 +0200)
>
> are available in the git repository at:
>
>   git://git.kiszka.org/linux.git queues/gpio-iot2000
>
> for you to fetch changes up to 413058df4331ce29f9934a5870d582c7e71fe15f:
>
>   serial: exar: Add support for IOT2040 device (2017-07-03 08:33:20 +0200)
>
> This corresponds to v6 of the series with additional review and ack
> tags.

Thanks Jan, pulled in for v4.13.

Also thanks for your tireless and gritty work in hashing this out
and get the right fix out there!

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web