Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670605 > unrolled thread
| Started by | Emil Velikov <emil.l.velikov@gmail.com> |
|---|---|
| First post | 2017-06-20 12:00 +0200 |
| Last post | 2017-06-20 13:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header Emil Velikov <emil.l.velikov@gmail.com> - 2017-06-20 12:00 +0200
Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-20 12:10 +0200
Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header Emil Velikov <emil.l.velikov@gmail.com> - 2017-06-20 13:00 +0200
Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-20 13:10 +0200
| From | Emil Velikov <emil.l.velikov@gmail.com> |
|---|---|
| Date | 2017-06-20 12:00 +0200 |
| Subject | Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header |
| Message-ID | <tUo70-6Xh-21@gated-at.bofh.it> |
On 19 June 2017 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Although header is included only once but still having an include guard
> is a good practice. To avoid confusion, add SoC prefix to existing
> Exynos5433 header include guard.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> include/video/exynos5433_decon.h | 6 +++---
> include/video/exynos7_decon.h | 5 +++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/video/exynos5433_decon.h b/include/video/exynos5433_decon.h
> index 78957c9626f5..b30362da5692 100644
> --- a/include/video/exynos5433_decon.h
> +++ b/include/video/exynos5433_decon.h
> @@ -6,8 +6,8 @@
> * published by the Free Software Foundationr
> */
>
> -#ifndef EXYNOS_REGS_DECON_H
> -#define EXYNOS_REGS_DECON_H
> +#ifndef EXYNOS5433_REGS_DECON_H
> +#define EXYNOS5433_REGS_DECON_H
>
Drop the _REGS_ part from the guard on each header? The file name/path
does not have it, plus it'll save some WTF moments when
exynos{5433,7}_regs_decon.h comes about.
Regards,
Emil
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-06-20 12:10 +0200 |
| Message-ID | <tUogG-7fS-31@gated-at.bofh.it> |
| In reply to | #1670605 |
On Tue, Jun 20, 2017 at 11:53 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 19 June 2017 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> Although header is included only once but still having an include guard
>> is a good practice. To avoid confusion, add SoC prefix to existing
>> Exynos5433 header include guard.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>> include/video/exynos5433_decon.h | 6 +++---
>> include/video/exynos7_decon.h | 5 +++++
>> 2 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/video/exynos5433_decon.h b/include/video/exynos5433_decon.h
>> index 78957c9626f5..b30362da5692 100644
>> --- a/include/video/exynos5433_decon.h
>> +++ b/include/video/exynos5433_decon.h
>> @@ -6,8 +6,8 @@
>> * published by the Free Software Foundationr
>> */
>>
>> -#ifndef EXYNOS_REGS_DECON_H
>> -#define EXYNOS_REGS_DECON_H
>> +#ifndef EXYNOS5433_REGS_DECON_H
>> +#define EXYNOS5433_REGS_DECON_H
>>
> Drop the _REGS_ part from the guard on each header? The file name/path
> does not have it, plus it'll save some WTF moments when
> exynos{5433,7}_regs_decon.h comes about.
So maybe it makes sense to reorder these patches and use the guard
name matching final file name?
Best regards,
Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Emil Velikov <emil.l.velikov@gmail.com> |
|---|---|
| Date | 2017-06-20 13:00 +0200 |
| Message-ID | <tUp34-7yf-29@gated-at.bofh.it> |
| In reply to | #1670630 |
On 20 June 2017 at 11:02, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Tue, Jun 20, 2017 at 11:53 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 19 June 2017 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> Although header is included only once but still having an include guard
>>> is a good practice. To avoid confusion, add SoC prefix to existing
>>> Exynos5433 header include guard.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> ---
>>> include/video/exynos5433_decon.h | 6 +++---
>>> include/video/exynos7_decon.h | 5 +++++
>>> 2 files changed, 8 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/include/video/exynos5433_decon.h b/include/video/exynos5433_decon.h
>>> index 78957c9626f5..b30362da5692 100644
>>> --- a/include/video/exynos5433_decon.h
>>> +++ b/include/video/exynos5433_decon.h
>>> @@ -6,8 +6,8 @@
>>> * published by the Free Software Foundationr
>>> */
>>>
>>> -#ifndef EXYNOS_REGS_DECON_H
>>> -#define EXYNOS_REGS_DECON_H
>>> +#ifndef EXYNOS5433_REGS_DECON_H
>>> +#define EXYNOS5433_REGS_DECON_H
>>>
>> Drop the _REGS_ part from the guard on each header? The file name/path
>> does not have it, plus it'll save some WTF moments when
>> exynos{5433,7}_regs_decon.h comes about.
>
> So maybe it makes sense to reorder these patches and use the guard
> name matching final file name?
>
That sounds better, IMHO.
-Emil
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-06-20 13:10 +0200 |
| Message-ID | <tUpcJ-7R1-15@gated-at.bofh.it> |
| In reply to | #1670673 |
On Tue, Jun 20, 2017 at 12:57 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 20 June 2017 at 11:02, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Tue, Jun 20, 2017 at 11:53 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>>> On 19 June 2017 at 17:31, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> Although header is included only once but still having an include guard
>>>> is a good practice. To avoid confusion, add SoC prefix to existing
>>>> Exynos5433 header include guard.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>> ---
>>>> include/video/exynos5433_decon.h | 6 +++---
>>>> include/video/exynos7_decon.h | 5 +++++
>>>> 2 files changed, 8 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/include/video/exynos5433_decon.h b/include/video/exynos5433_decon.h
>>>> index 78957c9626f5..b30362da5692 100644
>>>> --- a/include/video/exynos5433_decon.h
>>>> +++ b/include/video/exynos5433_decon.h
>>>> @@ -6,8 +6,8 @@
>>>> * published by the Free Software Foundationr
>>>> */
>>>>
>>>> -#ifndef EXYNOS_REGS_DECON_H
>>>> -#define EXYNOS_REGS_DECON_H
>>>> +#ifndef EXYNOS5433_REGS_DECON_H
>>>> +#define EXYNOS5433_REGS_DECON_H
>>>>
>>> Drop the _REGS_ part from the guard on each header? The file name/path
>>> does not have it, plus it'll save some WTF moments when
>>> exynos{5433,7}_regs_decon.h comes about.
>>
>> So maybe it makes sense to reorder these patches and use the guard
>> name matching final file name?
>>
> That sounds better, IMHO.
OK then, I'll re-order the patches and use matching name
(EXYNOS_REGS_DECON{5433,7}_H).
Best regards,
Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web