Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670392 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-06-20 10:00 +0200 |
| Last post | 2017-06-20 16:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] backlight: pwm_bl: make of_device_ids const Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-20 10:00 +0200
Re: [PATCH] backlight: pwm_bl: make of_device_ids const Daniel Thompson <daniel.thompson@linaro.org> - 2017-06-20 13:00 +0200
Re: [PATCH] backlight: pwm_bl: make of_device_ids const "Jingoo Han" <jingoohan1@gmail.com> - 2017-06-20 16:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-20 10:00 +0200 |
| Subject | [PATCH] backlight: pwm_bl: make of_device_ids const |
| Message-ID | <tUmeS-5LQ-25@gated-at.bofh.it> |
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/backlight/pwm_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 002f1ce..9bd1768 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
return 0;
}
-static struct of_device_id pwm_backlight_of_match[] = {
+static const struct of_device_id pwm_backlight_of_match[] = {
{ .compatible = "pwm-backlight" },
{ }
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Daniel Thompson <daniel.thompson@linaro.org> |
|---|---|
| Date | 2017-06-20 13:00 +0200 |
| Message-ID | <tUp34-7yf-21@gated-at.bofh.it> |
| In reply to | #1670392 |
On 20/06/17 08:52, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/pwm_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 002f1ce..9bd1768 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
> return 0;
> }
>
> -static struct of_device_id pwm_backlight_of_match[] = {
> +static const struct of_device_id pwm_backlight_of_match[] = {
> { .compatible = "pwm-backlight" },
> { }
> };
>
[toc] | [prev] | [next] | [standalone]
| From | "Jingoo Han" <jingoohan1@gmail.com> |
|---|---|
| Date | 2017-06-20 16:00 +0200 |
| Message-ID | <tUrRg-Tl-31@gated-at.bofh.it> |
| In reply to | #1670670 |
On Tuesday, June 20, 2017 6:53 AM, Daniel Thompson wrote:
>
> On 20/06/17 08:52, Arvind Yadav wrote:
> > of_device_ids are not supposed to change at runtime. All functions
> > working with of_device_ids provided by <linux/of.h> work with const
> > of_device_ids. So mark the non-const structs as const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
>
>
> > ---
> > drivers/video/backlight/pwm_bl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> b/drivers/video/backlight/pwm_bl.c
> > index 002f1ce..9bd1768 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
> > return 0;
> > }
> >
> > -static struct of_device_id pwm_backlight_of_match[] = {
> > +static const struct of_device_id pwm_backlight_of_match[] = {
> > { .compatible = "pwm-backlight" },
> > { }
> > };
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web