Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1668145 > unrolled thread

[PATCH V2] staging: unisys: visorhba - style fix

Started byDerek Robson <robsonde@gmail.com>
First post2017-06-17 05:20 +0200
Last post2017-06-20 00:10 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH V2] staging: unisys: visorhba - style fix Derek Robson <robsonde@gmail.com> - 2017-06-17 05:20 +0200
    RE: [PATCH V2] staging: unisys: visorhba - style fix "Kershner, David A" <David.Kershner@unisys.com> - 2017-06-19 17:30 +0200
      Re: [PATCH V2] staging: unisys: visorhba - style fix "Tobin C. Harding" <me@tobin.cc> - 2017-06-20 00:10 +0200

#1668145 — [PATCH V2] staging: unisys: visorhba - style fix

FromDerek Robson <robsonde@gmail.com>
Date2017-06-17 05:20 +0200
Subject[PATCH V2] staging: unisys: visorhba - style fix
Message-ID<tTcrf-14O-1@gated-at.bofh.it>
Fixed style of permissions to octal.
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>

V1 has vauge subject
---
 drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
 		goto err_scsi_remove_host;
 	}
 	devdata->debugfs_info =
-		debugfs_create_file("info", S_IRUSR | S_IRGRP,
+		debugfs_create_file("info", 0440,
 				    devdata->debugfs_dir, devdata,
 				    &info_debugfs_fops);
 	if (!devdata->debugfs_info) {
-- 
2.13.0

[toc] | [next] | [standalone]

#1669255

From"Kershner, David A" <David.Kershner@unisys.com>
Date2017-06-19 17:30 +0200
Message-ID<tU6MQ-4pB-55@gated-at.bofh.it>
In reply to#1668145
> -----Original Message-----
> From: Derek Robson [mailto:robsonde@gmail.com]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Binder, David Anthony <David.Binder@unisys.com>; Wadgaonkar, Sameer
> Laxmikant <Sameer.Wadgaonkar@unisys.com>;
> marcos.souza.org@gmail.com; robsonde@gmail.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>

I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit. 


> 
> V1 has vauge subject
> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>  		goto err_scsi_remove_host;
>  	}
>  	devdata->debugfs_info =
> -		debugfs_create_file("info", S_IRUSR | S_IRGRP,
> +		debugfs_create_file("info", 0440,
>  				    devdata->debugfs_dir, devdata,
>  				    &info_debugfs_fops);
>  	if (!devdata->debugfs_info) {
> --
> 2.13.0

[toc] | [prev] | [next] | [standalone]

#1669997

From"Tobin C. Harding" <me@tobin.cc>
Date2017-06-20 00:10 +0200
Message-ID<tUd1V-8vL-31@gated-at.bofh.it>
In reply to#1669255
On Mon, Jun 19, 2017 at 03:28:19PM +0000, Kershner, David A wrote:
> 
> > -----Original Message-----
> > From: Derek Robson [mailto:robsonde@gmail.com]
> > Sent: Friday, June 16, 2017 11:13 PM
> > To: Kershner, David A <David.Kershner@unisys.com>;
> > gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>;
> > Binder, David Anthony <David.Binder@unisys.com>; Wadgaonkar, Sameer
> > Laxmikant <Sameer.Wadgaonkar@unisys.com>;
> > marcos.souza.org@gmail.com; robsonde@gmail.com
> > Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> > devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH V2] staging: unisys: visorhba - style fix
> > 
> > Fixed style of permissions to octal.
> > Found using checkpatch
> > 
> > Signed-off-by: Derek Robson <robsonde@gmail.com>
> 
> I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit. 

Derek, for clarification what David means is that the version notes
should go below the dotted line so as not to be included in the patch
commit. You may also like to read
Documentation/process/submitting-patches.rst for tips on writing your
commit log (specifically section 2).

> 
> 
> > 
> > V1 has vauge subject
> > ---

v1 -> v2
 - fix vague subject

> >  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> > b/drivers/staging/unisys/visorhba/visorhba_main.c
> > index 2fd31c9762c6..a6e7a6bbc428 100644
> > --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> > +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> > @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> >  		goto err_scsi_remove_host;
> >  	}
> >  	devdata->debugfs_info =
> > -		debugfs_create_file("info", S_IRUSR | S_IRGRP,
> > +		debugfs_create_file("info", 0440,
> >  				    devdata->debugfs_dir, devdata,
> >  				    &info_debugfs_fops);
> >  	if (!devdata->debugfs_info) {
> > --
> > 2.13.0
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Good luck,
Tobin.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web