Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1671185 > unrolled thread
| Started by | frowand.list@gmail.com |
|---|---|
| First post | 2017-06-21 00:10 +0200 |
| Last post | 2017-06-22 01:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v6 0/4] of: remove *phandle properties from expanded device tree frowand.list@gmail.com - 2017-06-21 00:10 +0200
[PATCH v6 2/4] of: make __of_attach_node() static frowand.list@gmail.com - 2017-06-21 00:10 +0200
Re: [PATCH v6 2/4] of: make __of_attach_node() static Stephen Boyd <sboyd@codeaurora.org> - 2017-06-22 01:50 +0200
| From | frowand.list@gmail.com |
|---|---|
| Date | 2017-06-21 00:10 +0200 |
| Subject | [PATCH v6 0/4] of: remove *phandle properties from expanded device tree |
| Message-ID | <tUzvs-5W2-7@gated-at.bofh.it> |
From: Frank Rowand <frank.rowand@sony.com>
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field and will still be displayed as if it is a property
in /proc/device_tree.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to const void *. As
a result of the type change, the overlay code had compile errors
where the resolver updates phandle values.
[1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html
Patch 1 is the phandle related changes.
Patches 2 - 4 are minor fixups for issues that became visible
while implementing patch 1.
Changes from v5:
- patch 1: populate_properties(), prop_is_phandle was declared
at the wrong scope and thus was initialized before the for
loop instead of each time through the loop. This resulted
in any property in a node after the phandle property not
being unflattened.
Changes from v4:
- rebase on 4.12-rc1
- Add reason for "<NULL>" in of_attach_node()
- Simplify and consolidate phandle detection logic in
populate_properties(). This results in a change of behaviour,
the value of property "ibm,phandle" will no longer override the
value of properties "phandle" and "linux,phandle".
Changes from v3:
- patch 1: fix incorrect variable name in __of_add_phandle_sysfs().
Problem was reported by the kbuild test robot
Changes from v2:
- patch 1: Remove check in __of_add_phandle_sysfs() that would not
add a sysfs entry if IS_ENABLED(CONFIG_PPC_PSERIES)
Changes from v1:
- Remove phandle properties in of_attach_node(), before attaching
the node to the live tree.
- Add the phandle sysfs entry for the node in of_attach_node().
- When creating an overlay changeset, duplicate the node phandle in
__of_node_dup().
*** BLURB HERE ***
Frank Rowand (4):
of: remove *phandle properties from expanded device tree
of: make __of_attach_node() static
of: be consistent in form of file mode
of: detect invalid phandle in overlay
drivers/of/base.c | 50 +++++++++++++++++++++++++++++++++++++++----
drivers/of/dynamic.c | 57 +++++++++++++++++++++++++++++++++++++------------
drivers/of/fdt.c | 43 ++++++++++++++++++-------------------
drivers/of/of_private.h | 2 +-
drivers/of/overlay.c | 8 ++++---
drivers/of/resolver.c | 23 +-------------------
include/linux/of.h | 1 +
7 files changed, 118 insertions(+), 66 deletions(-)
--
Frank Rowand <frank.rowand@sony.com>
[toc] | [next] | [standalone]
| From | frowand.list@gmail.com |
|---|---|
| Date | 2017-06-21 00:10 +0200 |
| Subject | [PATCH v6 2/4] of: make __of_attach_node() static |
| Message-ID | <tUzvt-5W2-47@gated-at.bofh.it> |
| In reply to | #1671185 |
From: Frank Rowand <frank.rowand@sony.com>
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/dynamic.c | 2 +-
drivers/of/of_private.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index be320082178f..3367ed2da9ad 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -216,7 +216,7 @@ int of_property_notify(int action, struct device_node *np,
return of_reconfig_notify(action, &pr);
}
-void __of_attach_node(struct device_node *np)
+static void __of_attach_node(struct device_node *np)
{
np->child = NULL;
np->sibling = np->parent->child;
diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
index 1a041411b219..73da291a51cd 100644
--- a/drivers/of/of_private.h
+++ b/drivers/of/of_private.h
@@ -91,7 +91,6 @@ extern int __of_update_property(struct device_node *np,
extern void __of_update_property_sysfs(struct device_node *np,
struct property *newprop, struct property *oldprop);
-extern void __of_attach_node(struct device_node *np);
extern int __of_attach_node_sysfs(struct device_node *np);
extern void __of_detach_node(struct device_node *np);
extern void __of_detach_node_sysfs(struct device_node *np);
--
Frank Rowand <frank.rowand@sony.com>
[toc] | [prev] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-06-22 01:50 +0200 |
| Subject | Re: [PATCH v6 2/4] of: make __of_attach_node() static |
| Message-ID | <tUXxL-4Ng-9@gated-at.bofh.it> |
| In reply to | #1671187 |
On 06/20, frowand.list@gmail.com wrote: > From: Frank Rowand <frank.rowand@sony.com> > > __of_attach_node() is not used outside of drivers/of/dynamic.c. Make > it static and remove it from drivers/of/of_private.h. > > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web