Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671591 > unrolled thread

[PATCH][mm-next] mm: clean up build warning with unused variable ret2

Back to article view | Back to linux.kernel

Contents

  [PATCH][mm-next] mm: clean up build warning with unused variable ret2 Colin King <colin.king@canonical.com> - 2017-06-21 12:20 +0200
    Re: [PATCH][mm-next] mm: clean up build warning with unused  variable ret2 Jeff Layton <jlayton@redhat.com> - 2017-06-21 12:30 +0200

#1671591 — [PATCH][mm-next] mm: clean up build warning with unused variable ret2

From: Colin Ian King <colin.king@canonical.com>

Variable ret2 is unused and should be removed. Cleans up
build warning:

warning: unused variable 'ret2' [-Wunused-variable]

Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 64b75bd996a4..0b60cc7ddac2 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
 int write_one_page(struct page *page)
 {
 	struct address_space *mapping = page->mapping;
-	int ret = 0, ret2;
+	int ret = 0;
 	struct writeback_control wbc = {
 		.sync_mode = WB_SYNC_ALL,
 		.nr_to_write = 1,
-- 
2.11.0

[toc] | [next] | [standalone]

#1671596 — Re: [PATCH][mm-next] mm: clean up build warning with unused variable ret2

On Wed, 2017-06-21 at 11:14 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable ret2 is unused and should be removed. Cleans up
> build warning:
> 
> warning: unused variable 'ret2' [-Wunused-variable]
> 
> Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  mm/page-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 64b75bd996a4..0b60cc7ddac2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
>  int write_one_page(struct page *page)
>  {
>  	struct address_space *mapping = page->mapping;
> -	int ret = 0, ret2;
> +	int ret = 0;
>  	struct writeback_control wbc = {
>  		.sync_mode = WB_SYNC_ALL,
>  		.nr_to_write = 1,


Thanks. I just squashed the same fix into the original patch this
morning after seeing the mail from Stephen. Tomorrow's linux-next pull
should pick up the corrected version.
-- 
Jeff Layton <jlayton@redhat.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web