Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671500 > unrolled thread

[PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

Back to article view | Back to linux.kernel

Contents

  [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure Bhumika Goyal <bhumirks@gmail.com> - 2017-06-21 10:50 +0200
    Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops  structure Luca Coelho <luca@coelho.fi> - 2017-06-28 14:00 +0200
      Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops  structure Luca Coelho <luca@coelho.fi> - 2017-06-29 19:10 +0200

#1671500 — [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

Declare thermal_cooling_device_ops structure as const as it is only passed
as an argument to the function thermal_cooling_device_register and this
argument is of type const. So, declare the structure as const.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 453a785..0b5a177 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -813,7 +813,7 @@ static int iwl_mvm_tcool_set_cur_state(struct thermal_cooling_device *cdev,
 	return ret;
 }
 
-static struct thermal_cooling_device_ops tcooling_ops = {
+static const struct thermal_cooling_device_ops tcooling_ops = {
 	.get_max_state = iwl_mvm_tcool_get_max_state,
 	.get_cur_state = iwl_mvm_tcool_get_cur_state,
 	.set_cur_state = iwl_mvm_tcool_set_cur_state,
-- 
2.7.4

[toc] | [next] | [standalone]

#1676592 — Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only passed
> as an argument to the function thermal_cooling_device_register and this
> argument is of type const. So, declare the structure as const.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---

Thanks, we're reviewing this internally.  It looks fine, but I need to
assess whether this will have any impacts in our backports project
before we can apply it.

--
Cheers,
Luca.

[toc] | [prev] | [next] | [standalone]

#1677960 — Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure

On Wed, 2017-06-28 at 14:49 +0300, Luca Coelho wrote:
> On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> > Declare thermal_cooling_device_ops structure as const as it is only passed
> > as an argument to the function thermal_cooling_device_register and this
> > argument is of type const. So, declare the structure as const.
> > 
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> > ---
> 
> Thanks, we're reviewing this internally.  It looks fine, but I need to
> assess whether this will have any impacts in our backports project
> before we can apply it.

This has been applied in our internal tree and will eventually land in
the mainline.

Thanks!

--
Cheers,
Luca.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web