Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671440 > unrolled thread

Re: [PATCH] staging/lustre: echo_client.c - fix sparse warning: cast removes address space of expression

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging/lustre: echo_client.c - fix sparse warning: cast  removes address space of expression Tordek <kedrot@gmail.com> - 2017-06-21 09:30 +0200

#1671440 — Re: [PATCH] staging/lustre: echo_client.c - fix sparse warning: cast removes address space of expression

Hi, List

I don't want to be a bother but should I be doing something different
when submitting patches? I know it's minor but it's a simple change
and it's received no response after two weeks; not even a rejection.

Cheers
--
Tordek

On 8 June 2017 at 02:35, Guillermo O. Freschi <kedrot@gmail.com> wrote:
> The function only cares about the value of the pointer, not the contents
> of the pointed-to data. Adding a `__force` annotation to the cast
> removes this warning.
>
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
> ---
>  drivers/staging/lustre/lustre/obdecho/echo_client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c
> index d4768311cf92..1757714c56a0 100644
> --- a/drivers/staging/lustre/lustre/obdecho/echo_client.c
> +++ b/drivers/staging/lustre/lustre/obdecho/echo_client.c
> @@ -1428,7 +1428,7 @@ static int echo_client_brw_ioctl(const struct lu_env *env, int rw,
>         oa->o_valid &= ~OBD_MD_FLHANDLE;
>
>         /* OFD/obdfilter works only via prep/commit */
> -       test_mode = (long)data->ioc_pbuf1;
> +       test_mode = (__force long)data->ioc_pbuf1;
>         if (test_mode == 1)
>                 async = 0;
>
> --
> 2.11.0
>

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web