Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671109 > unrolled thread

[PATCH] drivers/fsi: fix fsi_slave_mode prototype

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers/fsi: fix fsi_slave_mode prototype Arnd Bergmann <arnd@arndb.de> - 2017-06-20 22:50 +0200
    Re: [PATCH] drivers/fsi: fix fsi_slave_mode prototype Jeremy Kerr <jk@ozlabs.org> - 2017-06-21 03:00 +0200

#1671109 — [PATCH] drivers/fsi: fix fsi_slave_mode prototype

gcc warns about the return type of this function:

drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

This removes the 'const' attribute, as suggested by the warning.

Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/fsi/fsi-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index a485864cb512..f2e08932e2d9 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -532,7 +532,7 @@ static inline uint32_t fsi_smode_sid(int x)
 	return (x & FSI_SMODE_SID_MASK) << FSI_SMODE_SID_SHIFT;
 }
 
-static const uint32_t fsi_slave_smode(int id)
+static uint32_t fsi_slave_smode(int id)
 {
 	return FSI_SMODE_WSC | FSI_SMODE_ECRC
 		| fsi_smode_sid(id)
-- 
2.9.0

[toc] | [next] | [standalone]

#1671264

Hi Arnd,

> gcc warns about the return type of this function:
> 
> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
> 
> This removes the 'const' attribute, as suggested by the warning.

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web