Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669487 > unrolled thread
| Started by | Aravind Thokala <aravind.thk@gmail.com> |
|---|---|
| First post | 2017-06-19 19:00 +0200 |
| Last post | 2017-06-19 19:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings Aravind Thokala <aravind.thk@gmail.com> - 2017-06-19 19:00 +0200
Re: [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings Florian Fainelli <f.fainelli@gmail.com> - 2017-06-19 19:30 +0200
Re: [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings Aravind Thokala <aravind.thk@gmail.com> - 2017-06-19 19:50 +0200
| From | Aravind Thokala <aravind.thk@gmail.com> |
|---|---|
| Date | 2017-06-19 19:00 +0200 |
| Subject | [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings |
| Message-ID | <tU8bU-5do-17@gated-at.bofh.it> |
This patch fixes the checkpatch.pl warnings on the driver
file.
Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
---
drivers/spi/spi-bcm63xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 247f71b..84c7356 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -147,7 +147,7 @@ struct bcm63xx_spi {
/* Platform data */
const unsigned long *reg_offsets;
- unsigned fifo_size;
+ unsigned int fifo_size;
unsigned int msg_type_shift;
unsigned int msg_ctl_width;
@@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
#endif
}
-static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
+static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
{ 20000000, SPI_CLK_20MHZ },
{ 12500000, SPI_CLK_12_50MHZ },
{ 6250000, SPI_CLK_6_250MHZ },
--
2.7.4
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-06-19 19:30 +0200 |
| Message-ID | <tU8EW-5CR-21@gated-at.bofh.it> |
| In reply to | #1669487 |
On 06/19/2017 09:49 AM, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
>
> Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
The subject should be spi/bcm63xx: Fix checkpatch warnings to be
consistent with previous submissions done to that file.
With that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/spi/spi-bcm63xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 247f71b..84c7356 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -147,7 +147,7 @@ struct bcm63xx_spi {
>
> /* Platform data */
> const unsigned long *reg_offsets;
> - unsigned fifo_size;
> + unsigned int fifo_size;
> unsigned int msg_type_shift;
> unsigned int msg_ctl_width;
>
> @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
> #endif
> }
>
> -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
> +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
> { 20000000, SPI_CLK_20MHZ },
> { 12500000, SPI_CLK_12_50MHZ },
> { 6250000, SPI_CLK_6_250MHZ },
>
--
Florian
[toc] | [prev] | [next] | [standalone]
| From | Aravind Thokala <aravind.thk@gmail.com> |
|---|---|
| Date | 2017-06-19 19:50 +0200 |
| Message-ID | <tU8Yh-5Lk-17@gated-at.bofh.it> |
| In reply to | #1669534 |
Hi Florian,
On 19 June 2017 at 22:51, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 06/19/2017 09:49 AM, Aravind Thokala wrote:
>> This patch fixes the checkpatch.pl warnings on the driver
>> file.
>>
>> Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
>
> The subject should be spi/bcm63xx: Fix checkpatch warnings to be
> consistent with previous submissions done to that file.
Thanks, I will send v2 patch with the change in subject.
>
> With that:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thank you for reviewing the patch.
Aravind.
>
>> ---
>> drivers/spi/spi-bcm63xx.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
>> index 247f71b..84c7356 100644
>> --- a/drivers/spi/spi-bcm63xx.c
>> +++ b/drivers/spi/spi-bcm63xx.c
>> @@ -147,7 +147,7 @@ struct bcm63xx_spi {
>>
>> /* Platform data */
>> const unsigned long *reg_offsets;
>> - unsigned fifo_size;
>> + unsigned int fifo_size;
>> unsigned int msg_type_shift;
>> unsigned int msg_ctl_width;
>>
>> @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
>> #endif
>> }
>>
>> -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
>> +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
>> { 20000000, SPI_CLK_20MHZ },
>> { 12500000, SPI_CLK_12_50MHZ },
>> { 6250000, SPI_CLK_6_250MHZ },
>>
>
>
> --
> Florian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web