Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669001 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-19 13:00 +0200 |
| Last post | 2017-06-19 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King <colin.king@canonical.com> - 2017-06-19 13:00 +0200
Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-19 13:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-19 13:00 +0200 |
| Subject | [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static |
| Message-ID | <tU2zv-1xF-11@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The guid intel_dsm_guid does not need to be in global scope, so make
it static.
Cleans up sparse warning:
"symbol 'intel_dsm_guid' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mmc/host/sdhci-pci-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 3c02c5b394d6..f1d8385d91f0 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -404,7 +404,7 @@ struct intel_host {
bool d3_retune;
};
-const guid_t intel_dsm_guid =
+static const guid_t intel_dsm_guid =
GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
--
2.11.0
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-06-19 13:10 +0200 |
| Subject | Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm_guid static |
| Message-ID | <tU2Jb-1RM-7@gated-at.bofh.it> |
| In reply to | #1669001 |
On 19 June 2017 at 12:55, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
Both me and Adrian have acked this, so it's fine to pick up by Christoph.
Kind regards
Uffe
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
> --
> 2.11.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web