Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1668630 > unrolled thread

[PATCH] pptp: Remove unused variable in pptp_release()

Started byChristos Gkekas <chris.gekas@gmail.com>
First post2017-06-18 17:50 +0200
Last post2017-06-19 06:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] pptp: Remove unused variable in pptp_release() Christos Gkekas <chris.gekas@gmail.com> - 2017-06-18 17:50 +0200
    Re: [PATCH] pptp: Remove unused variable in pptp_release() David Miller <davem@davemloft.net> - 2017-06-19 06:00 +0200

#1668630 — [PATCH] pptp: Remove unused variable in pptp_release()

FromChristos Gkekas <chris.gekas@gmail.com>
Date2017-06-18 17:50 +0200
Subject[PATCH] pptp: Remove unused variable in pptp_release()
Message-ID<tTKCB-6Ye-7@gated-at.bofh.it>
Variable opt in pptp_release() is set but never used, thus needs to be
removed.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/net/ppp/pptp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
index 1951b10..5b0fd89 100644
--- a/drivers/net/ppp/pptp.c
+++ b/drivers/net/ppp/pptp.c
@@ -506,7 +506,6 @@ static int pptp_release(struct socket *sock)
 {
 	struct sock *sk = sock->sk;
 	struct pppox_sock *po;
-	struct pptp_opt *opt;
 	int error = 0;
 
 	if (!sk)
@@ -520,7 +519,6 @@ static int pptp_release(struct socket *sock)
 	}
 
 	po = pppox_sk(sk);
-	opt = &po->proto.pptp;
 	del_chan(po);
 
 	pppox_unbind_sock(sk);
-- 
2.7.4

[toc] | [next] | [standalone]


#1668752

FromDavid Miller <davem@davemloft.net>
Date2017-06-19 06:00 +0200
Message-ID<tTW13-5Of-1@gated-at.bofh.it>
In reply to#1668630
From: Christos Gkekas <chris.gekas@gmail.com>
Date: Sun, 18 Jun 2017 16:41:40 +0100

> Variable opt in pptp_release() is set but never used, thus needs to be
> removed.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>

Applied to net-next.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web