Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1665172 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-06-13 22:50 +0200 |
| Last post | 2017-06-16 22:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtlwifi: rtl8821ae: remove unused variable "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-13 22:50 +0200
Re: [PATCH] rtlwifi: rtl8821ae: remove unused variable Larry Finger <Larry.Finger@lwfinger.net> - 2017-06-16 22:40 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-13 22:50 +0200 |
| Subject | [PATCH] rtlwifi: rtl8821ae: remove unused variable |
| Message-ID | <tS0Vc-4dS-11@gated-at.bofh.it> |
Remove unused variable rtlhal.
Addresses-Coverity-ID: 1248810
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
index 2bc6bac..d158e34 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
@@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw,
static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv);
u8 fw_reason = 0;
struct timeval ts;
@@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
ppsc->wakeup_reason = 0;
- rtlhal->last_suspend_sec = ts.tv_sec;
-
switch (fw_reason) {
case FW_WOW_V2_PTK_UPDATE_EVENT:
ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE;
--
2.5.0
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-06-16 22:40 +0200 |
| Message-ID | <tT6ca-58r-7@gated-at.bofh.it> |
| In reply to | #1665172 |
On 06/13/2017 03:42 PM, Gustavo A. R. Silva wrote:
> Remove unused variable rtlhal.
>
> Addresses-Coverity-ID: 1248810
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
NACK!! That variable is used in file core.c in driver rtlwifi, which is loaded
and used by rtl8821ae.
Please do more than blindly follow Coverity outputs, or improve that tool!
Larry
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 2bc6bac..d158e34 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1360,7 +1360,6 @@ static bool _rtl8821ae_reset_pcie_interface_dma(struct ieee80211_hw *hw,
> static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> - struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
> struct rtl_ps_ctl *ppsc = rtl_psc(rtlpriv);
> u8 fw_reason = 0;
> struct timeval ts;
> @@ -1372,8 +1371,6 @@ static void _rtl8821ae_get_wakeup_reason(struct ieee80211_hw *hw)
>
> ppsc->wakeup_reason = 0;
>
> - rtlhal->last_suspend_sec = ts.tv_sec;
> -
> switch (fw_reason) {
> case FW_WOW_V2_PTK_UPDATE_EVENT:
> ppsc->wakeup_reason = WOL_REASON_PTK_UPDATE;
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web