Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1666592 > unrolled thread
| Started by | Srinath Mannam <srinath.mannam@broadcom.com> |
|---|---|
| First post | 2017-06-15 11:20 +0200 |
| Last post | 2017-06-16 20:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: gadget: bdc: 64-bit pointer capability check Srinath Mannam <srinath.mannam@broadcom.com> - 2017-06-15 11:20 +0200
Re: [PATCH] usb: gadget: bdc: 64-bit pointer capability check Florian Fainelli <f.fainelli@gmail.com> - 2017-06-16 20:30 +0200
| From | Srinath Mannam <srinath.mannam@broadcom.com> |
|---|---|
| Date | 2017-06-15 11:20 +0200 |
| Subject | [PATCH] usb: gadget: bdc: 64-bit pointer capability check |
| Message-ID | <tSz6x-C2-9@gated-at.bofh.it> |
Corrected the register to check the 64-bit pointer
capability state. 64-bit pointer implementation capability
was checking in wrong register, which causes the BDC
enumeration failure in 64-bit memory address.
Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for
Broadcom USB3.0 device controller IP BDC")
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index ccb9c21..e9bd8d4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -475,7 +475,7 @@ static int bdc_probe(struct platform_device *pdev)
bdc->dev = dev;
dev_dbg(bdc->dev, "bdc->regs: %p irq=%d\n", bdc->regs, bdc->irq);
- temp = bdc_readl(bdc->regs, BDC_BDCSC);
+ temp = bdc_readl(bdc->regs, BDC_BDCCAP1);
if ((temp & BDC_P64) &&
!dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
dev_dbg(bdc->dev, "Using 64-bit address\n");
--
2.7.4
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-06-16 20:30 +0200 |
| Message-ID | <tT4am-3MU-17@gated-at.bofh.it> |
| In reply to | #1666592 |
On 06/15/2017 02:09 AM, Srinath Mannam wrote:
> Corrected the register to check the 64-bit pointer
> capability state. 64-bit pointer implementation capability
> was checking in wrong register, which causes the BDC
> enumeration failure in 64-bit memory address.
>
> Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for
> Broadcom USB3.0 device controller IP BDC")
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web