Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1666481 > unrolled thread
| Started by | Minghsiu Tsai <minghsiu.tsai@mediatek.com> |
|---|---|
| First post | 2017-06-15 08:30 +0200 |
| Last post | 2017-06-15 10:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic Minghsiu Tsai <minghsiu.tsai@mediatek.com> - 2017-06-15 08:30 +0200
Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic Hans Verkuil <hverkuil@xs4all.nl> - 2017-06-15 10:50 +0200
| From | Minghsiu Tsai <minghsiu.tsai@mediatek.com> |
|---|---|
| Date | 2017-06-15 08:30 +0200 |
| Subject | Re: [PATCH v2] [media] mtk-mdp: Fix g_/s_selection capture/compose logic |
| Message-ID | <tSws1-7nJ-1@gated-at.bofh.it> |
Hi, Hans,
Would you have time to review this patch v2?
The patch v1 violates v4l2 spec. I have fixed it in v2.
Sincerely,
Ming Hsiu
On Fri, 2017-05-12 at 10:42 +0800, Minghsiu Tsai wrote:
> From: Daniel Kurtz <djkurtz@chromium.org>
>
> Experiments show that the:
> (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT
> (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
> Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
>
> ---
> Changes in v2:
> . Can not use *_MPLANE type in g_/s_selection
> ---
> drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> index 13afe48..e18ac626 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> @@ -838,10 +838,10 @@ static int mtk_mdp_m2m_g_selection(struct file *file, void *fh,
> bool valid = false;
>
> if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - if (mtk_mdp_is_target_compose(s->target))
> + if (mtk_mdp_is_target_crop(s->target))
> valid = true;
> } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
> - if (mtk_mdp_is_target_crop(s->target))
> + if (mtk_mdp_is_target_compose(s->target))
> valid = true;
> }
> if (!valid) {
> @@ -908,10 +908,10 @@ static int mtk_mdp_m2m_s_selection(struct file *file, void *fh,
> bool valid = false;
>
> if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> - if (s->target == V4L2_SEL_TGT_COMPOSE)
> + if (s->target == V4L2_SEL_TGT_CROP)
> valid = true;
> } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
> - if (s->target == V4L2_SEL_TGT_CROP)
> + if (s->target == V4L2_SEL_TGT_COMPOSE)
> valid = true;
> }
> if (!valid) {
> @@ -925,7 +925,7 @@ static int mtk_mdp_m2m_s_selection(struct file *file, void *fh,
> if (ret)
> return ret;
>
> - if (mtk_mdp_is_target_crop(s->target))
> + if (mtk_mdp_is_target_compose(s->target))
> frame = &ctx->s_frame;
> else
> frame = &ctx->d_frame;
[toc] | [next] | [standalone]
| From | Hans Verkuil <hverkuil@xs4all.nl> |
|---|---|
| Date | 2017-06-15 10:50 +0200 |
| Message-ID | <tSyDx-cv-43@gated-at.bofh.it> |
| In reply to | #1666481 |
On 06/15/17 08:29, Minghsiu Tsai wrote:
> Hi, Hans,
>
> Would you have time to review this patch v2?
> The patch v1 violates v4l2 spec. I have fixed it in v2.
I plan to review it Friday or Monday.
Regards,
Hans
>
>
> Sincerely,
> Ming Hsiu
>
> On Fri, 2017-05-12 at 10:42 +0800, Minghsiu Tsai wrote:
>> From: Daniel Kurtz <djkurtz@chromium.org>
>>
>> Experiments show that the:
>> (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT
>> (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets
>>
>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
>> Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
>>
>> ---
>> Changes in v2:
>> . Can not use *_MPLANE type in g_/s_selection
>> ---
>> drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
>> index 13afe48..e18ac626 100644
>> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
>> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
>> @@ -838,10 +838,10 @@ static int mtk_mdp_m2m_g_selection(struct file *file, void *fh,
>> bool valid = false;
>>
>> if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
>> - if (mtk_mdp_is_target_compose(s->target))
>> + if (mtk_mdp_is_target_crop(s->target))
>> valid = true;
>> } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
>> - if (mtk_mdp_is_target_crop(s->target))
>> + if (mtk_mdp_is_target_compose(s->target))
>> valid = true;
>> }
>> if (!valid) {
>> @@ -908,10 +908,10 @@ static int mtk_mdp_m2m_s_selection(struct file *file, void *fh,
>> bool valid = false;
>>
>> if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
>> - if (s->target == V4L2_SEL_TGT_COMPOSE)
>> + if (s->target == V4L2_SEL_TGT_CROP)
>> valid = true;
>> } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
>> - if (s->target == V4L2_SEL_TGT_CROP)
>> + if (s->target == V4L2_SEL_TGT_COMPOSE)
>> valid = true;
>> }
>> if (!valid) {
>> @@ -925,7 +925,7 @@ static int mtk_mdp_m2m_s_selection(struct file *file, void *fh,
>> if (ret)
>> return ret;
>>
>> - if (mtk_mdp_is_target_crop(s->target))
>> + if (mtk_mdp_is_target_compose(s->target))
>> frame = &ctx->s_frame;
>> else
>> frame = &ctx->d_frame;
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web