Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662081 > unrolled thread
| Started by | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| First post | 2017-06-09 10:20 +0200 |
| Last post | 2017-06-15 07:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Matthias Brugger <matthias.bgg@gmail.com> - 2017-06-09 10:20 +0200
Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Weiqing Kong <weiqing.kong@mediatek.com> - 2017-06-15 07:40 +0200
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2017-06-09 10:20 +0200 |
| Subject | Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 |
| Message-ID | <tQnjc-7y0-13@gated-at.bofh.it> |
On 01/06/17 08:08, Erin Lo wrote:
> From: YT Shen <yt.shen@mediatek.com>
I miss the Singed-off-by from YT Shen.
>
> This patch adds the device node of display backlight for MT2701
>
> Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com>
> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> ---
> arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++
> arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++
> 2 files changed, 38 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index a483798..e49c2b7 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -22,6 +22,35 @@
> memory {
> reg = <0 0x80000000 0 0x40000000>;
> };
> +
> + backlight_lcd: backlight_lcd {
> + compatible = "pwm-backlight";
> + pwms = <&bls 0 100000>;
> + brightness-levels = <
> + 0 16 32 48 64 80 96 112
> + 128 144 160 176 192 208 224 240
> + 255
> + >;
> + default-brightness-level = <9>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm_bls_gpio>;
> + };
> +};
> +
> +&bls {
> + status = "okay";
> +};
> +
> +&mmsys {
> + status = "okay";
> +};
> +
> +&pio {
> + pwm_bls_gpio: pwm_bls_gpio {
> + pins_cmd_dat {
> + pinmux = <MT2701_PIN_208_AUD_EXT_CK1__FUNC_DISP_PWM>;
> + };
> + };
> };
>
> &auxadc {
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index de88bd7..4f110d5 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -366,6 +366,15 @@
> #clock-cells = <1>;
> };
>
> + bls: bls@1400a000 {
> + compatible = "mediatek,mt2701-disp-pwm";
> + reg = <0 0x1400a000 0 0x1000>;
> + #pwm-cells = <2>;
> + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>;
> + clock-names = "main", "mm";
> + status = "disabled";
> + };
> +
Can you make this a new patch please. It's preferred to have one patch
for the dtsi and another one for the actual board.
Thanks,
Matthias
> larb0: larb@14010000 {
> compatible = "mediatek,mt2701-smi-larb";
> reg = <0 0x14010000 0 0x1000>;
>
[toc] | [next] | [standalone]
| From | Weiqing Kong <weiqing.kong@mediatek.com> |
|---|---|
| Date | 2017-06-15 07:40 +0200 |
| Message-ID | <tSvFD-6PF-1@gated-at.bofh.it> |
| In reply to | #1662081 |
On Fri, 2017-06-09 at 10:12 +0200, Matthias Brugger wrote:
>
> On 01/06/17 08:08, Erin Lo wrote:
> > From: YT Shen <yt.shen@mediatek.com>
>
> I miss the Singed-off-by from YT Shen.
>
> >
> > This patch adds the device node of display backlight for MT2701
> >
> > Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com>
> > Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > ---
> > arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++
> > arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++
> > 2 files changed, 38 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> > index a483798..e49c2b7 100644
> > --- a/arch/arm/boot/dts/mt2701-evb.dts
> > +++ b/arch/arm/boot/dts/mt2701-evb.dts
> > @@ -22,6 +22,35 @@
> > memory {
> > reg = <0 0x80000000 0 0x40000000>;
> > };
> > +
> > + backlight_lcd: backlight_lcd {
> > + compatible = "pwm-backlight";
> > + pwms = <&bls 0 100000>;
> > + brightness-levels = <
> > + 0 16 32 48 64 80 96 112
> > + 128 144 160 176 192 208 224 240
> > + 255
> > + >;
> > + default-brightness-level = <9>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm_bls_gpio>;
> > + };
> > +};
> > +
> > +&bls {
> > + status = "okay";
> > +};
> > +
> > +&mmsys {
> > + status = "okay";
> > +};
> > +
> > +&pio {
> > + pwm_bls_gpio: pwm_bls_gpio {
> > + pins_cmd_dat {
> > + pinmux = <MT2701_PIN_208_AUD_EXT_CK1__FUNC_DISP_PWM>;
> > + };
> > + };
> > };
> >
> > &auxadc {
> > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> > index de88bd7..4f110d5 100644
> > --- a/arch/arm/boot/dts/mt2701.dtsi
> > +++ b/arch/arm/boot/dts/mt2701.dtsi
> > @@ -366,6 +366,15 @@
> > #clock-cells = <1>;
> > };
> >
> > + bls: bls@1400a000 {
> > + compatible = "mediatek,mt2701-disp-pwm";
> > + reg = <0 0x1400a000 0 0x1000>;
> > + #pwm-cells = <2>;
> > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>;
> > + clock-names = "main", "mm";
> > + status = "disabled";
> > + };
> > +
>
> Can you make this a new patch please. It's preferred to have one patch
> for the dtsi and another one for the actual board.
>
> Thanks,
> Matthias
OK, I will split it into two patches.
Thanks,
Weiqing Kong
>
> > larb0: larb@14010000 {
> > compatible = "mediatek,mt2701-smi-larb";
> > reg = <0 0x14010000 0 0x1000>;
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web