Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664677 > unrolled thread

Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 12:10 +0200
    RE: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com> - 2017-06-14 15:20 +0200

#1664677 — Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> Reorder fields in the device's private structure such that
> the ones most used on the hotpath are at the beginning of
> the structure.
> 
> This brings a small performance improvement due to better
> cache usage.

Really?  What kind of performance improvement?  Always be specific.

Please fix up and resend.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1665819

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, June 13, 2017 1:04 PM
> To: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>
> Cc: devel@driverdev.osuosl.org; stuyoder@gmail.com; arnd@arndb.de;
> linux-kernel@vger.kernel.org; agraf@suse.de; Bharat Bhushan
> <bharat.bhushan@nxp.com>; Bogdan Purcareata
> <bogdan.purcareata@nxp.com>; linux-arm-kernel@lists.infradead.org;
> Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Subject: Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields
> 
> On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> > Reorder fields in the device's private structure such that
> > the ones most used on the hotpath are at the beginning of
> > the structure.
> >
> > This brings a small performance improvement due to better
> > cache usage.
> 
> Really?  What kind of performance improvement?  Always be specific.

Fair point, thanks.

The test scenario was ipfwd with small frames and the improvement ~1%,
but I took this patch from an internal repo, so I need to redo the
measurements on the current tree before resending.

> 
> Please fix up and resend.

We're preparing a larger patchset with several optimizations, I'll
probably include the v2 there.

Thanks,
Ioana

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web