Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661869 > unrolled thread

RE: [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [lkp-robot] [EDAC, sb_edac]  e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com> - 2017-06-09 04:30 +0200
    Re: [lkp-robot] [EDAC, sb_edac]  e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error Borislav Petkov <bp@alien8.de> - 2017-06-09 11:50 +0200
      RE: [lkp-robot] [EDAC, sb_edac]  e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com> - 2017-06-10 06:20 +0200
        Re: [lkp-robot] [EDAC, sb_edac]  e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error Ye Xiaolong <xiaolong.ye@intel.com> - 2017-06-12 03:40 +0200
          Re: [LKP] [lkp-robot] [EDAC, sb_edac] e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error Ye Xiaolong <xiaolong.ye@intel.com> - 2017-06-12 07:20 +0200
            Re: [LKP] [lkp-robot] [EDAC, sb_edac] e2f747b1f4:  kmsg.EDAC_sbridge:Failed_to_register_device_with_error Borislav Petkov <bp@alien8.de> - 2017-06-14 12:00 +0200

#1661869 — RE: [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error

Hi Xiaolong,

    Fixed this issue by 'EDAC, sb_edac: Avoid creating 'SOCK' EDAC memory controller' (you were also CCed by 'Reported-by').
    Thanks for this test case :-)

BR
qiuxu

-----Original Message-----
From: Zhuo, Qiuxu 
Sent: Monday, June 5, 2017 9:08 PM
To: Ye, Xiaolong <xiaolong.ye@intel.com>
Cc: Borislav Petkov <bp@suse.de>; linux-edac <linux-edac@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; Stephen Rothwell <sfr@canb.auug.org.au>; lkp@01.org
Subject: RE: [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error

Hi Xiaolong,

   Thanks!  I'll look at it, and feedback ASAP.

BR
qiuxu

-----Original Message-----
From: lkp-robot-request@eclists.intel.com [mailto:lkp-robot-request@eclists.intel.com] On Behalf Of Ye, Xiaolong
Sent: Monday, June 5, 2017 2:23 PM
To: Zhuo, Qiuxu <qiuxu.zhuo@intel.com>
Cc: Borislav Petkov <bp@suse.de>; linux-edac <linux-edac@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; Stephen Rothwell <sfr@canb.auug.org.au>; lkp@01.org
Subject: [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error


FYI, we noticed the following commit:

commit: e2f747b1f42a2f6b0cf5416be1684c1b94a42f0f ("EDAC, sb_edac: Assign EDAC memory controller per h/w controller") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

in testcase: netperf
with following parameters:

	ip: ipv4
	runtime: 300s
	nr_threads: 25%
	cluster: cs-localhost
	test: TCP_CRR
	cpufreq_governor: performance

test-description: Netperf is a benchmark that can be use to measure various aspect of networking performance.
test-url: http://www.netperf.org/netperf/


on test machine: 16 threads Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz with 8G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):


kern  :err   : [   17.309988] EDAC sbridge: Some needed devices are missing
kern  :info  : [   17.504765] ast 0000:07:00.0: fb0: astdrmfb frame buffer device
kern  :info  : [   17.533508] EDAC MC: Removed device 0 for sbridge_edac.c Broadwell SrcID#0_Ha#0: DEV 0000:ff:12.0
kern  :err   : [   17.533529] EDAC sbridge: Couldn't find mci handler
kern  :err   : [   17.533530] EDAC sbridge: Failed to register device with error -19.




To reproduce:

        git clone https://github.com/01org/lkp-tests.git
        cd lkp-tests
        bin/lkp install job.yaml  # job file is attached in this email
        bin/lkp run     job.yaml



Thanks,
Xiaolong

[toc] | [next] | [standalone]

#1662195

On Fri, Jun 09, 2017 at 02:28:30AM +0000, Zhuo, Qiuxu wrote:
> Hi Xiaolong,
> 
>     Fixed this issue by 'EDAC, sb_edac: Avoid creating 'SOCK' EDAC memory controller' (you were also CCed by 'Reported-by').
>     Thanks for this test case :-)

Xiaolong,

can you please run Qiuxu's patch to verify it fixes your issue?

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [next] | [standalone]

#1662873

[Multipart message — attachments visible in raw view] — view raw

> From: Borislav Petkov [mailto:bp@alien8.de] 
>
> Xiaolong,
>
> can you please run Qiuxu's patch to verify it fixes your issue?


Hi Boris,
    I manually verified the fix patch on the Broadwell-DE server on which the bug was found by Xiaolong: 
    the sb_edac can be loaded successfully, and it identified which size and type of DIMMs were installed
    in each slot correctly (see attached dmesg.sb_edac.on.Broadwell-DE.log).

Hi Xiaolong,
   Would you please also test the patch by your LKP method by which the issue was found last time.

Thanks!

BR
Qiuxu 
    
    
    

[toc] | [prev] | [next] | [standalone]

#1663180

On 06/10, Zhuo, Qiuxu wrote:
>> From: Borislav Petkov [mailto:bp@alien8.de] 
>>
>> Xiaolong,
>>
>> can you please run Qiuxu's patch to verify it fixes your issue?
>
>
>Hi Boris,
>    I manually verified the fix patch on the Broadwell-DE server on which the bug was found by Xiaolong: 
>    the sb_edac can be loaded successfully, and it identified which size and type of DIMMs were installed
>    in each slot correctly (see attached dmesg.sb_edac.on.Broadwell-DE.log).
>
>Hi Xiaolong,
>   Would you please also test the patch by your LKP method by which the issue was found last time.
>

Got it, I've queued test jobs for your fix patch, will let you know the result
once I get the it.

Thanks,
Xiaolong


>Thanks!
>
>BR
>Qiuxu 
>    
>    
>    

[toc] | [prev] | [next] | [standalone]

#1663248 — Re: [LKP] [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error

On 06/12, Ye Xiaolong wrote:
>On 06/10, Zhuo, Qiuxu wrote:
>>> From: Borislav Petkov [mailto:bp@alien8.de] 
>>>
>>> Xiaolong,
>>>
>>> can you please run Qiuxu's patch to verify it fixes your issue?
>>
>>
>>Hi Boris,
>>    I manually verified the fix patch on the Broadwell-DE server on which the bug was found by Xiaolong: 
>>    the sb_edac can be loaded successfully, and it identified which size and type of DIMMs were installed
>>    in each slot correctly (see attached dmesg.sb_edac.on.Broadwell-DE.log).
>>
>>Hi Xiaolong,
>>   Would you please also test the patch by your LKP method by which the issue was found last time.
>>
>
>Got it, I've queued test jobs for your fix patch, will let you know the result
>once I get the it.

Confirmed the error is gone with qiuxu's fix patch.


Tested-by: From: Ye Xiaolong <xiaolong.ye@intel.com>

Thanks,
Xiaolong
>
>Thanks,
>Xiaolong
>
>
>>Thanks!
>>
>>BR
>>Qiuxu 
>>    
>>    
>>    
>
>
>_______________________________________________
>LKP mailing list
>LKP@lists.01.org
>https://lists.01.org/mailman/listinfo/lkp

[toc] | [prev] | [next] | [standalone]

#1665664 — Re: [LKP] [lkp-robot] [EDAC, sb_edac] e2f747b1f4: kmsg.EDAC_sbridge:Failed_to_register_device_with_error

On Mon, Jun 12, 2017 at 01:11:13PM +0800, Ye Xiaolong wrote:
> Confirmed the error is gone with qiuxu's fix patch.
> 
> Tested-by: From: Ye Xiaolong <xiaolong.ye@intel.com>

Thanks guys, I massaged it a bit and ended up applying this:

---
From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Date: Thu, 8 Jun 2017 19:33:51 +0800
Subject: [PATCH] EDAC, sb_edac: Avoid creating SOCK memory controller

Xiaolong Ye reported the following failure on Broadwell D server:

  EDAC sbridge: Some needed devices are missing
  EDAC MC: Removed device 0 for sbridge_edac.c Broadwell SrcID#0_Ha#0: DEV 0000:ff:12.0
  EDAC sbridge: Couldn't find mci handler
  EDAC sbridge: Failed to register device with error -19.

Broadwell D (only IMC0 per socket) and Broadwell X (IMC0 and IMC1 per
socket) use the same PCI device IDs for IMC0 per socket, then they
share pci_dev_descr_broadwell_table (n_imcs_per_sock=2). In this case,
Broadwell D wrongly creates the nonexistent SOCK EDAC memory controller
and reports above error messages, since it has no IMC1 per socket.

Avoid creating the nonexistent SOCK memory controller.

Reported-and-tested-by: Xiaolong Ye <xiaolong.ye@intel.com>
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170608113351.25323-1-qiuxu.zhuo@intel.com
[ Massage. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/edac/sb_edac.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 89fd6bd64df6..80d860cb0746 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -2260,6 +2260,10 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
 next_imc:
 	sbridge_dev = get_sbridge_dev(bus, dev_descr->dom, multi_bus, sbridge_dev);
 	if (!sbridge_dev) {
+
+		if (dev_descr->dom == SOCK)
+			goto out_imc;
+
 		sbridge_dev = alloc_sbridge_dev(bus, dev_descr->dom, table);
 		if (!sbridge_dev) {
 			pci_dev_put(pdev);
@@ -2285,6 +2289,7 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
 	if (dev_descr->dom == SOCK && i < table->n_imcs_per_sock)
 		goto next_imc;
 
+out_imc:
 	/* Be sure that the device is enabled */
 	if (unlikely(pci_enable_device(pdev) < 0)) {
 		sbridge_printk(KERN_ERR,
-- 
2.13.0

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web