Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665159 > unrolled thread

[PATCH] tty/serial: remove AVR32 specific access wrappers

Started byAlexandre Belloni <alexandre.belloni@free-electrons.com>
First post2017-06-13 22:30 +0200
Last post2017-06-14 15:40 +0200
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-13 22:30 +0200
    Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Richard Genoud <richard.genoud@gmail.com> - 2017-06-14 09:50 +0200
    Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-14 11:50 +0200
      Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-14 15:30 +0200
        Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-14 16:20 +0200
          Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-14 16:30 +0200
    Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-14 12:50 +0200
      Re: [PATCH] tty/serial: remove AVR32 specific access wrappers Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-14 15:40 +0200

#1665159 — [PATCH] tty/serial: remove AVR32 specific access wrappers

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-06-13 22:30 +0200
Subject[PATCH] tty/serial: remove AVR32 specific access wrappers
Message-ID<tS0BQ-46W-9@gated-at.bofh.it>
Now that AVR32 is gone, the specific wrappers for that architecture are
unnecessary and will not be compiled anymore.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/tty/serial/atmel_serial.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 937d67f22fba..8bfc566df2da 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value)
 	__raw_writel(value, port->membase + reg);
 }
 
-#ifdef CONFIG_AVR32
-
-/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */
-static inline u8 atmel_uart_read_char(struct uart_port *port)
-{
-	return __raw_readl(port->membase + ATMEL_US_RHR);
-}
-
-static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
-{
-	__raw_writel(value, port->membase + ATMEL_US_THR);
-}
-
-#else
-
 static inline u8 atmel_uart_read_char(struct uart_port *port)
 {
 	return __raw_readb(port->membase + ATMEL_US_RHR);
@@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
 	__raw_writeb(value, port->membase + ATMEL_US_THR);
 }
 
-#endif
-
 #ifdef CONFIG_SERIAL_ATMEL_PDC
 static bool atmel_use_pdc_rx(struct uart_port *port)
 {
-- 
2.11.0

[toc] | [next] | [standalone]

#1665524

FromRichard Genoud <richard.genoud@gmail.com>
Date2017-06-14 09:50 +0200
Message-ID<tSbdT-2l2-3@gated-at.bofh.it>
In reply to#1665159
On 13/06/2017 22:25, Alexandre Belloni wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Richard Genoud <richard.genoud@gmail.com>

[toc] | [prev] | [next] | [standalone]

#1665648

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-14 11:50 +0200
Message-ID<tSd62-3uV-23@gated-at.bofh.it>
In reply to#1665159
On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
>

Can you rebase this on top of tty-next?

I'm pretty sure this patch will gone.

> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 17 -----------------
>  1 file changed, 17 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 937d67f22fba..8bfc566df2da 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -228,21 +228,6 @@ static inline void atmel_uart_writel(struct uart_port *port, u32 reg, u32 value)
>         __raw_writel(value, port->membase + reg);
>  }
>
> -#ifdef CONFIG_AVR32
> -
> -/* AVR32 cannot handle 8 or 16bit I/O accesses but only 32bit I/O accesses */
> -static inline u8 atmel_uart_read_char(struct uart_port *port)
> -{
> -       return __raw_readl(port->membase + ATMEL_US_RHR);
> -}
> -
> -static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
> -{
> -       __raw_writel(value, port->membase + ATMEL_US_THR);
> -}
> -
> -#else
> -
>  static inline u8 atmel_uart_read_char(struct uart_port *port)
>  {
>         return __raw_readb(port->membase + ATMEL_US_RHR);
> @@ -253,8 +238,6 @@ static inline void atmel_uart_write_char(struct uart_port *port, u8 value)
>         __raw_writeb(value, port->membase + ATMEL_US_THR);
>  }
>
> -#endif
> -
>  #ifdef CONFIG_SERIAL_ATMEL_PDC
>  static bool atmel_use_pdc_rx(struct uart_port *port)
>  {
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1665827

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-06-14 15:30 +0200
Message-ID<tSgwW-5I4-15@gated-at.bofh.it>
In reply to#1665648
On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Now that AVR32 is gone, the specific wrappers for that architecture are
> > unnecessary and will not be compiled anymore.
> >
> 
> Can you rebase this on top of tty-next?
> 
> I'm pretty sure this patch will gone.
> 

So you avoided most of the bikeshedding by not copying any of the
maintainers, nice...


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1665872

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-14 16:20 +0200
Message-ID<tShjj-6eD-9@gated-at.bofh.it>
In reply to#1665827
On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
>> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>> > Now that AVR32 is gone, the specific wrappers for that architecture are
>> > unnecessary and will not be compiled anymore.
>> >
>>
>> Can you rebase this on top of tty-next?
>>
>> I'm pretty sure this patch will gone.
>>
>
> So you avoided most of the bikeshedding by not copying any of the
> maintainers, nice...

Wait, what? I used get_maintainer.pl script and I took its output + Greg.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1665882

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-06-14 16:30 +0200
Message-ID<tSht0-6j2-33@gated-at.bofh.it>
In reply to#1665872
On 14/06/2017 at 17:15:32 +0300, Andy Shevchenko wrote:
> On Wed, Jun 14, 2017 at 4:27 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > On 14/06/2017 at 12:43:40 +0300, Andy Shevchenko wrote:
> >> On Tue, Jun 13, 2017 at 11:25 PM, Alexandre Belloni
> >> <alexandre.belloni@free-electrons.com> wrote:
> >> > Now that AVR32 is gone, the specific wrappers for that architecture are
> >> > unnecessary and will not be compiled anymore.
> >> >
> >>
> >> Can you rebase this on top of tty-next?
> >>
> >> I'm pretty sure this patch will gone.
> >>
> >
> > So you avoided most of the bikeshedding by not copying any of the
> > maintainers, nice...
> 
> Wait, what? I used get_maintainer.pl script and I took its output + Greg.
> 

Yeah, get_maintainer is not ideal but that's fine. Probably the lakml
should be added.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1665693

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-06-14 12:50 +0200
Message-ID<tSe26-459-31@gated-at.bofh.it>
In reply to#1665159
On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote:
> Now that AVR32 is gone, the specific wrappers for that architecture are
> unnecessary and will not be compiled anymore.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Does not apply to my tty-next tree at all :(

[toc] | [prev] | [next] | [standalone]

#1665836

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-06-14 15:40 +0200
Message-ID<tSgGC-5Le-7@gated-at.bofh.it>
In reply to#1665693
On 14/06/2017 at 12:49:29 +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2017 at 10:25:17PM +0200, Alexandre Belloni wrote:
> > Now that AVR32 is gone, the specific wrappers for that architecture are
> > unnecessary and will not be compiled anymore.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> >  drivers/tty/serial/atmel_serial.c | 17 -----------------
> >  1 file changed, 17 deletions(-)
> 
> Does not apply to my tty-next tree at all :(
> 

That's fine, as Andy pointed out, he did the job.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web