Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1667588 > unrolled thread

[PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning

Started byJaya Durga <jayad@cdac.in>
First post2017-06-16 11:40 +0200
Last post2017-06-16 11:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning Jaya Durga <jayad@cdac.in> - 2017-06-16 11:40 +0200
    Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted  __le16 sparse warning Greg KH <gregkh@linuxfoundation.org> - 2017-06-16 11:50 +0200

#1667588 — [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning

FromJaya Durga <jayad@cdac.in>
Date2017-06-16 11:40 +0200
Subject[PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning
Message-ID<tSVTs-6D9-19@gated-at.bofh.it>
warning: cast to restricted __le16

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index a812e55..0e95e45 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3380,7 +3380,7 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
	u16 fc;

	/* Byte order convert once up front. */
-	usbin->rxfrm.desc.status = le16_to_cpu(usbin->rxfrm.desc.status);
+	le16_to_cpus(&usbin->rxfrm.desc.status);
	usbin->rxfrm.desc.time = le32_to_cpu(usbin->rxfrm.desc.time);

	/* Now handle frame based on port# */
--
1.9.1

[toc] | [next] | [standalone]


#1667593 — Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-16 11:50 +0200
SubjectRe: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed cast to restricted __le16 sparse warning
Message-ID<tSW37-6Go-11@gated-at.bofh.it>
In reply to#1667588
On Fri, Jun 16, 2017 at 02:57:08PM +0530, Jaya Durga wrote:
> warning: cast to restricted __le16

What does this mean?  It doesn't tell us why you are doing what you are
doing here.

Please be much more specific and descriptive.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web