Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1666965 > unrolled thread
| Started by | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| First post | 2017-06-15 20:00 +0200 |
| Last post | 2017-06-16 18:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Kim Phillips <kim.phillips@arm.com> - 2017-06-15 20:00 +0200
Re: [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Adrian Hunter <adrian.hunter@intel.com> - 2017-06-16 09:00 +0200
Re: [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Ingo Molnar <mingo@kernel.org> - 2017-06-16 10:10 +0200
[PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Kim Phillips <kim.phillips@arm.com> - 2017-06-16 18:30 +0200
Re: [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-16 18:30 +0200
| From | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| Date | 2017-06-15 20:00 +0200 |
| Subject | [PATCH 1/2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array |
| Message-ID | <tSHdN-5vC-53@gated-at.bofh.it> |
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
tools/perf/arch/x86/util/intel-bts.c | 4 ----
tools/perf/arch/x86/util/intel-pt.c | 4 ----
tools/perf/util/intel-bts.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
index af2bce7a2cd6..781df40b2966 100644
--- a/tools/perf/arch/x86/util/intel-bts.c
+++ b/tools/perf/arch/x86/util/intel-bts.c
@@ -35,10 +35,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
-
struct intel_bts_snapshot_ref {
void *ref_buf;
size_t ref_offset;
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index f630de0206a1..6fe667b3269e 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -40,10 +40,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
-
#define INTEL_PT_PSB_PERIOD_NEAR 256
struct intel_pt_snapshot_ref {
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index b2834ac7b1f5..218ee2bac9a5 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
}
-u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
-
int intel_bts_process_auxtrace_info(union perf_event *event,
struct perf_session *session)
{
--
2.11.0
[toc] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-06-16 09:00 +0200 |
| Message-ID | <tSToD-4Ym-31@gated-at.bofh.it> |
| In reply to | #1666965 |
On 15/06/17 20:55, Kim Phillips wrote:
>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Looks like defines for sampling support that got mixed in with earlier
patches. We can always put them back when we need them, so:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/arch/x86/util/intel-bts.c | 4 ----
> tools/perf/arch/x86/util/intel-pt.c | 4 ----
> tools/perf/util/intel-bts.c | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
> index af2bce7a2cd6..781df40b2966 100644
> --- a/tools/perf/arch/x86/util/intel-bts.c
> +++ b/tools/perf/arch/x86/util/intel-bts.c
> @@ -35,10 +35,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
> -
> struct intel_bts_snapshot_ref {
> void *ref_buf;
> size_t ref_offset;
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index f630de0206a1..6fe667b3269e 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -40,10 +40,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
> -
> #define INTEL_PT_PSB_PERIOD_NEAR 256
>
> struct intel_pt_snapshot_ref {
> diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
> index b2834ac7b1f5..218ee2bac9a5 100644
> --- a/tools/perf/util/intel-bts.c
> +++ b/tools/perf/util/intel-bts.c
> @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
> fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
> }
>
> -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
> -
> int intel_bts_process_auxtrace_info(union perf_event *event,
> struct perf_session *session)
> {
>
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-06-16 10:10 +0200 |
| Message-ID | <tSUum-5Te-7@gated-at.bofh.it> |
| In reply to | #1667465 |
* Adrian Hunter <adrian.hunter@intel.com> wrote: > On 15/06/17 20:55, Kim Phillips wrote: > > > > Signed-off-by: Kim Phillips <kim.phillips@arm.com> > > Looks like defines for sampling support that got mixed in with earlier > patches. We can always put them back when we need them, so: > > Acked-by: Adrian Hunter <adrian.hunter@intel.com> The non-existent changelog is wholly inadequate though. Thanks, Ingo
[toc] | [prev] | [next] | [standalone]
| From | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| Date | 2017-06-16 18:30 +0200 |
| Subject | [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array |
| Message-ID | <tT2id-2u9-5@gated-at.bofh.it> |
| In reply to | #1667511 |
These defines were probably dragged in from sampling support in earlier
patches. They can be put back when needed.
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
v2: addressed Ingo's comment by populating changelog with Adrian's
explanation of why they were unused
tools/perf/arch/x86/util/intel-bts.c | 4 ----
tools/perf/arch/x86/util/intel-pt.c | 4 ----
tools/perf/util/intel-bts.c | 2 --
3 files changed, 10 deletions(-)
diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
index af2bce7a2cd6..781df40b2966 100644
--- a/tools/perf/arch/x86/util/intel-bts.c
+++ b/tools/perf/arch/x86/util/intel-bts.c
@@ -35,10 +35,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
-
struct intel_bts_snapshot_ref {
void *ref_buf;
size_t ref_offset;
diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
index f630de0206a1..6fe667b3269e 100644
--- a/tools/perf/arch/x86/util/intel-pt.c
+++ b/tools/perf/arch/x86/util/intel-pt.c
@@ -40,10 +40,6 @@
#define KiB_MASK(x) (KiB(x) - 1)
#define MiB_MASK(x) (MiB(x) - 1)
-#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
-
-#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
-
#define INTEL_PT_PSB_PERIOD_NEAR 256
struct intel_pt_snapshot_ref {
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index b2834ac7b1f5..218ee2bac9a5 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
}
-u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
-
int intel_bts_process_auxtrace_info(union perf_event *event,
struct perf_session *session)
{
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-06-16 18:30 +0200 |
| Subject | Re: [PATCH 1/2 v2] perf intel-pt/bts: remove unused SAMPLE_SIZE defines and bts priv array |
| Message-ID | <tT2ie-2u9-19@gated-at.bofh.it> |
| In reply to | #1667874 |
Em Fri, Jun 16, 2017 at 11:23:39AM -0500, Kim Phillips escreveu:
> These defines were probably dragged in from sampling support in earlier
> patches. They can be put back when needed.
Applied.
Ah, please capitalize the first word after the : in the summary, i.e.:
[PATCH 1/2 v2] perf intel-pt/bts: Remove unused SAMPLE_SIZE
Thanks,
- Arnaldo
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> ---
> v2: addressed Ingo's comment by populating changelog with Adrian's
> explanation of why they were unused
>
> tools/perf/arch/x86/util/intel-bts.c | 4 ----
> tools/perf/arch/x86/util/intel-pt.c | 4 ----
> tools/perf/util/intel-bts.c | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-bts.c b/tools/perf/arch/x86/util/intel-bts.c
> index af2bce7a2cd6..781df40b2966 100644
> --- a/tools/perf/arch/x86/util/intel-bts.c
> +++ b/tools/perf/arch/x86/util/intel-bts.c
> @@ -35,10 +35,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_BTS_DFLT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_BTS_MAX_SAMPLE_SIZE KiB(60)
> -
> struct intel_bts_snapshot_ref {
> void *ref_buf;
> size_t ref_offset;
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index f630de0206a1..6fe667b3269e 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -40,10 +40,6 @@
> #define KiB_MASK(x) (KiB(x) - 1)
> #define MiB_MASK(x) (MiB(x) - 1)
>
> -#define INTEL_PT_DEFAULT_SAMPLE_SIZE KiB(4)
> -
> -#define INTEL_PT_MAX_SAMPLE_SIZE KiB(60)
> -
> #define INTEL_PT_PSB_PERIOD_NEAR 256
>
> struct intel_pt_snapshot_ref {
> diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
> index b2834ac7b1f5..218ee2bac9a5 100644
> --- a/tools/perf/util/intel-bts.c
> +++ b/tools/perf/util/intel-bts.c
> @@ -866,8 +866,6 @@ static void intel_bts_print_info(u64 *arr, int start, int finish)
> fprintf(stdout, intel_bts_info_fmts[i], arr[i]);
> }
>
> -u64 intel_bts_auxtrace_info_priv[INTEL_BTS_AUXTRACE_PRIV_SIZE];
> -
> int intel_bts_process_auxtrace_info(union perf_event *event,
> struct perf_session *session)
> {
> --
> 2.11.0
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web