Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1667232 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-06-15 22:20 +0200 |
| Last post | 2017-06-15 23:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] atm: solos-pci: remove useless variable assignments "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-15 22:20 +0200
Re: [PATCH] atm: solos-pci: remove useless variable assignments David Miller <davem@davemloft.net> - 2017-06-15 23:40 +0200
Re: [PATCH] atm: solos-pci: remove useless variable assignments "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-15 23:50 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-15 22:20 +0200 |
| Subject | [PATCH] atm: solos-pci: remove useless variable assignments |
| Message-ID | <tSJpg-75B-21@gated-at.bofh.it> |
Value assigned to variable _data32_ at lines 1254 and 1257 is
overwritten at line 1260 before it can be used. This makes
such variable assignments useless.
Addresses-Coverity-ID: 1227049
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/atm/solos-pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 5ad037c..9115b29 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -1251,10 +1251,10 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id)
if (reset) {
iowrite32(1, card->config_regs + FPGA_MODE);
- data32 = ioread32(card->config_regs + FPGA_MODE);
+ ioread32(card->config_regs + FPGA_MODE);
iowrite32(0, card->config_regs + FPGA_MODE);
- data32 = ioread32(card->config_regs + FPGA_MODE);
+ ioread32(card->config_regs + FPGA_MODE);
}
data32 = ioread32(card->config_regs + FPGA_VER);
--
2.5.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-06-15 23:40 +0200 |
| Message-ID | <tSKEF-7OC-5@gated-at.bofh.it> |
| In reply to | #1667232 |
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> Date: Thu, 15 Jun 2017 14:56:21 -0500 > Value assigned to variable _data32_ at lines 1254 and 1257 is > overwritten at line 1260 before it can be used. This makes > such variable assignments useless. > > Addresses-Coverity-ID: 1227049 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Applied, thanks.
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-15 23:50 +0200 |
| Message-ID | <tSKOm-7SX-17@gated-at.bofh.it> |
| In reply to | #1667285 |
Hi David, Quoting David Miller <davem@davemloft.net>: > From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> > Date: Thu, 15 Jun 2017 14:56:21 -0500 > >> Value assigned to variable _data32_ at lines 1254 and 1257 is >> overwritten at line 1260 before it can be used. This makes >> such variable assignments useless. >> >> Addresses-Coverity-ID: 1227049 >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > Applied, thanks. Absolutely, glad to help. Regards -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web