Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1666800 > unrolled thread

[PATCH] drivers:pcmcia:m32r_pcc:Check return value of request_region()

Started bynobble <nobbleren@gmail.com>
First post2017-06-15 17:20 +0200
Last post2017-06-15 17:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] drivers:pcmcia:m32r_pcc:Check return value of  request_region() nobble <nobbleren@gmail.com> - 2017-06-15 17:20 +0200

#1666800 — [PATCH] drivers:pcmcia:m32r_pcc:Check return value of request_region()

Fromnobble <nobbleren@gmail.com>
Date2017-06-15 17:20 +0200
Subject[PATCH] drivers:pcmcia:m32r_pcc:Check return value of request_region()
Message-ID<tSEIX-46h-25@gated-at.bofh.it>
request_region() can fail here and check its return value

Signed-off-by: nobbleRen <nobbleren@gmail.com>
---
 drivers/pcmcia/m32r_pcc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pcmcia/m32r_pcc.c b/drivers/pcmcia/m32r_pcc.c
index e50bbf8..5ab241a 100644
--- a/drivers/pcmcia/m32r_pcc.c
+++ b/drivers/pcmcia/m32r_pcc.c
@@ -316,7 +316,8 @@ static int add_pcc_socket(ulong base, int irq, ulong mapaddr,
 
 	/* add pcc */
 	if (t->base > 0) {
-		request_region(t->base, 0x20, "m32r-pcc");
+		if (!request_region(t->base, 0x20, "m32r-pcc"))
+			return -EBUSY;
 	}
 
 	printk(KERN_INFO "  %s ", pcc[pcc_sockets].name);
-- 
1.9.1

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web