Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662268 > unrolled thread

[PATCH] i2c: xgene-slimpro: include linux/io.h for memremap

Back to article view | Back to linux.kernel

Contents

  [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:40 +0200
    Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap Hoan Tran <hotran@apm.com> - 2017-06-09 19:30 +0200
    Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap Wolfram Sang <wsa@the-dreams.de> - 2017-06-15 16:00 +0200
      Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap Wolfram Sang <wsa@the-dreams.de> - 2017-06-18 15:10 +0200

#1662268 — [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap

The newly added support for the pcc mailbox fails to build
in some configurations:

drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in

This includes the missing header file.

Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/i2c/busses/i2c-xgene-slimpro.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 8e5c8f28bc8b..7e89ba6fcf6f 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -27,6 +27,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/mailbox_client.h>
 #include <linux/module.h>
 #include <linux/of.h>
-- 
2.9.0

[toc] | [next] | [standalone]

#1662641

Hi Arnd,

On Fri, Jun 9, 2017 at 3:29 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added support for the pcc mailbox fails to build
> in some configurations:
>
> drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
> drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
> drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in
>
> This includes the missing header file.
>
> Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/i2c/busses/i2c-xgene-slimpro.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
> index 8e5c8f28bc8b..7e89ba6fcf6f 100644
> --- a/drivers/i2c/busses/i2c-xgene-slimpro.c
> +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
> @@ -27,6 +27,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/i2c.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/mailbox_client.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> --
> 2.9.0
>

Reviewed-by: Hoan Tran <hotran@apm.com>

Thanks
Hoan

[toc] | [prev] | [next] | [standalone]

#1666742

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote:
> The newly added support for the pcc mailbox fails to build
> in some configurations:
> 
> drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
> drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
> drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in
> 
> This includes the missing header file.
> 
> Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to for-current, thanks!

[toc] | [prev] | [next] | [standalone]

#1668589

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 15, 2017 at 03:57:40PM +0200, Wolfram Sang wrote:
> On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote:
> > The newly added support for the pcc mailbox fails to build
> > in some configurations:
> > 
> > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
> > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in
> > 
> > This includes the missing header file.
> > 
> > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Applied to for-current, thanks!

Oops, the offending commit is only in for-next. So, reconsidered and
moved this patch to for-next as well.

Regards,

   Wolfram

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web