Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1666710 > unrolled thread

[PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select'

Started byHans de Goede <hdegoede@redhat.com>
First post2017-06-15 15:10 +0200
Last post2017-06-15 15:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select' Hans de Goede <hdegoede@redhat.com> - 2017-06-15 15:10 +0200
    [PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on' instead of 'select' Hans de Goede <hdegoede@redhat.com> - 2017-06-15 15:10 +0200
      Re: [PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on'  instead of 'select' Lee Jones <lee.jones@linaro.org> - 2017-06-15 15:50 +0200
    Re: [PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of  'select' Lee Jones <lee.jones@linaro.org> - 2017-06-15 15:50 +0200

#1666710 — [PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select'

FromHans de Goede <hdegoede@redhat.com>
Date2017-06-15 15:10 +0200
Subject[PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select'
Message-ID<tSCH8-2TS-7@gated-at.bofh.it>
From: Arnd Bergmann <arnd@arndb.de>

I ran into a build error on ARM with a platform that has a non-standard
clk implementation:

drivers/clk/clk.o: In function `clk_disable':
clk.c:(.text.clk_disable+0x0): multiple definition of `clk_disable'
arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_disable+0x0): first defined here
drivers/clk/clk.o: In function `clk_enable':
clk.c:(.text.clk_enable+0x0): multiple definition of `clk_enable'
arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_enable+0x0): first defined here

The problem is a device driver that uses 'select COMMON_CLK', which is
generally a bad idea: selecting a subsystem should only be done from
a platform, otherwise we run into circular dependencies. The same driver
also selects 'GPIOLIB' and 'I2C', which has a similar effect.

This turns all three into 'depends on', as it should be.

Finally, we can limit the build to x86, unless we are compile testing.

Fixes: 5f125f1f5705 ("mfd: intel_soc_pmic: Select designware i2c-bus driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-Split into 2 seperate patches for config INTEL_SOC_PMIC and
 config INTEL_SOC_PMIC_CHTWC
---
 drivers/mfd/Kconfig | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 95e868360e9a..2499f8b5135a 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -453,14 +453,12 @@ config LPC_SCH
 
 config INTEL_SOC_PMIC
 	bool "Support for Crystal Cove PMIC"
-	depends on HAS_IOMEM
-	select GPIOLIB
-	select I2C
+	depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK
+	depends on X86 || COMPILE_TEST
 	select MFD_CORE
 	select REGMAP_I2C
 	select REGMAP_IRQ
-	select COMMON_CLK
-	select I2C_DESIGNWARE_PLATFORM
+	select I2C_DESIGNWARE_PLATFORM if ACPI
 	help
 	  Select this option to enable support for Crystal Cove PMIC
 	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
-- 
2.13.0

[toc] | [next] | [standalone]

#1666711 — [PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on' instead of 'select'

FromHans de Goede <hdegoede@redhat.com>
Date2017-06-15 15:10 +0200
Subject[PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on' instead of 'select'
Message-ID<tSCH8-2TS-15@gated-at.bofh.it>
In reply to#1666710
From: Arnd Bergmann <arnd@arndb.de>

I ran into a build error on ARM with a platform that has a non-standard
clk implementation:

drivers/clk/clk.o: In function `clk_disable':
clk.c:(.text.clk_disable+0x0): multiple definition of `clk_disable'
arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_disable+0x0): first defined here
drivers/clk/clk.o: In function `clk_enable':
clk.c:(.text.clk_enable+0x0): multiple definition of `clk_enable'
arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_enable+0x0): first defined here

The problem is a device driver that uses 'select COMMON_CLK', which is
generally a bad idea: selecting a subsystem should only be done from
a platform, otherwise we run into circular dependencies. The same driver
also selects 'GPIOLIB' and 'I2C', which has a similar effect.

This turns all three into 'depends on', as it should be.

Finally, we can limit the build to x86, unless we are compile testing.

Fixes: 2f91ded5f8f4 ("mfd: Add Cherry Trail Whiskey Cove PMIC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-Split into 2 seperate patches for config INTEL_SOC_PMIC and
 config INTEL_SOC_PMIC_CHTWC
---
 drivers/mfd/Kconfig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 2499f8b5135a..1428814c33f9 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -481,13 +481,12 @@ config INTEL_SOC_PMIC_BXTWC
 	  on these systems.
 
 config INTEL_SOC_PMIC_CHTWC
-	bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
-	depends on ACPI && HAS_IOMEM
+	tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
+	depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
+	depends on X86 || COMPILE_TEST
 	select MFD_CORE
-	select I2C
 	select REGMAP_I2C
 	select REGMAP_IRQ
-	select COMMON_CLK
 	select I2C_DESIGNWARE_PLATFORM
 	help
 	  Select this option to enable support for the Intel Cherry Trail
-- 
2.13.0

[toc] | [prev] | [next] | [standalone]

#1666735 — Re: [PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on' instead of 'select'

FromLee Jones <lee.jones@linaro.org>
Date2017-06-15 15:50 +0200
SubjectRe: [PATCH v2 2/2] mfd: intel_soc_pmic_chtwc: use 'depends on' instead of 'select'
Message-ID<tSDjP-36J-5@gated-at.bofh.it>
In reply to#1666711
On Thu, 15 Jun 2017, Hans de Goede wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> I ran into a build error on ARM with a platform that has a non-standard
> clk implementation:
> 
> drivers/clk/clk.o: In function `clk_disable':
> clk.c:(.text.clk_disable+0x0): multiple definition of `clk_disable'
> arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_disable+0x0): first defined here
> drivers/clk/clk.o: In function `clk_enable':
> clk.c:(.text.clk_enable+0x0): multiple definition of `clk_enable'
> arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_enable+0x0): first defined here
> 
> The problem is a device driver that uses 'select COMMON_CLK', which is
> generally a bad idea: selecting a subsystem should only be done from
> a platform, otherwise we run into circular dependencies. The same driver
> also selects 'GPIOLIB' and 'I2C', which has a similar effect.
> 
> This turns all three into 'depends on', as it should be.
> 
> Finally, we can limit the build to x86, unless we are compile testing.
> 
> Fixes: 2f91ded5f8f4 ("mfd: Add Cherry Trail Whiskey Cove PMIC driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Split into 2 seperate patches for config INTEL_SOC_PMIC and
>  config INTEL_SOC_PMIC_CHTWC
> ---
>  drivers/mfd/Kconfig | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 2499f8b5135a..1428814c33f9 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -481,13 +481,12 @@ config INTEL_SOC_PMIC_BXTWC
>  	  on these systems.
>  
>  config INTEL_SOC_PMIC_CHTWC
> -	bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
> -	depends on ACPI && HAS_IOMEM
> +	tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
> +	depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
> +	depends on X86 || COMPILE_TEST
>  	select MFD_CORE
> -	select I2C
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> -	select COMMON_CLK
>  	select I2C_DESIGNWARE_PLATFORM
>  	help
>  	  Select this option to enable support for the Intel Cherry Trail

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1666738 — Re: [PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select'

FromLee Jones <lee.jones@linaro.org>
Date2017-06-15 15:50 +0200
SubjectRe: [PATCH v2 1/2] mfd: intel_soc_pmic: use 'depends on' instead of 'select'
Message-ID<tSDjP-36J-13@gated-at.bofh.it>
In reply to#1666710
On Thu, 15 Jun 2017, Hans de Goede wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> I ran into a build error on ARM with a platform that has a non-standard
> clk implementation:
> 
> drivers/clk/clk.o: In function `clk_disable':
> clk.c:(.text.clk_disable+0x0): multiple definition of `clk_disable'
> arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_disable+0x0): first defined here
> drivers/clk/clk.o: In function `clk_enable':
> clk.c:(.text.clk_enable+0x0): multiple definition of `clk_enable'
> arch/arm/mach-omap1/clock.o:clock.c:(.text.clk_enable+0x0): first defined here
> 
> The problem is a device driver that uses 'select COMMON_CLK', which is
> generally a bad idea: selecting a subsystem should only be done from
> a platform, otherwise we run into circular dependencies. The same driver
> also selects 'GPIOLIB' and 'I2C', which has a similar effect.
> 
> This turns all three into 'depends on', as it should be.
> 
> Finally, we can limit the build to x86, unless we are compile testing.
> 
> Fixes: 5f125f1f5705 ("mfd: intel_soc_pmic: Select designware i2c-bus driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Split into 2 seperate patches for config INTEL_SOC_PMIC and
>  config INTEL_SOC_PMIC_CHTWC
> ---
>  drivers/mfd/Kconfig | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 95e868360e9a..2499f8b5135a 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -453,14 +453,12 @@ config LPC_SCH
>  
>  config INTEL_SOC_PMIC
>  	bool "Support for Crystal Cove PMIC"
> -	depends on HAS_IOMEM
> -	select GPIOLIB
> -	select I2C
> +	depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK
> +	depends on X86 || COMPILE_TEST
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> -	select COMMON_CLK
> -	select I2C_DESIGNWARE_PLATFORM
> +	select I2C_DESIGNWARE_PLATFORM if ACPI
>  	help
>  	  Select this option to enable support for Crystal Cove PMIC
>  	  on some Intel SoC systems. The PMIC provides ADC, GPIO,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web