Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663593 > unrolled thread
| Started by | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| First post | 2017-06-12 17:20 +0200 |
| Last post | 2017-06-13 12:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 1/8] PM / Domains: Constify genpd pointer Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
Re: [PATCH v2 1/8] PM / Domains: Constify genpd pointer Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-13 12:40 +0200
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-06-12 17:20 +0200 |
| Subject | [PATCH v2 1/8] PM / Domains: Constify genpd pointer |
| Message-ID | <tRzii-3K9-11@gated-at.bofh.it> |
Mark pointer to struct generic_pm_domain const (either passed in
argument or used localy in a function), whenever it is not modifed by
the function itself.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/base/power/domain.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index da49a8383dc3..2e8d0f423507 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -126,7 +126,7 @@ static const struct genpd_lock_ops genpd_spin_ops = {
#define genpd_is_always_on(genpd) (genpd->flags & GENPD_FLAG_ALWAYS_ON)
static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev,
- struct generic_pm_domain *genpd)
+ const struct generic_pm_domain *genpd)
{
bool ret;
@@ -181,12 +181,14 @@ static struct generic_pm_domain *dev_to_genpd(struct device *dev)
return pd_to_genpd(dev->pm_domain);
}
-static int genpd_stop_dev(struct generic_pm_domain *genpd, struct device *dev)
+static int genpd_stop_dev(const struct generic_pm_domain *genpd,
+ struct device *dev)
{
return GENPD_DEV_CALLBACK(genpd, int, stop, dev);
}
-static int genpd_start_dev(struct generic_pm_domain *genpd, struct device *dev)
+static int genpd_start_dev(const struct generic_pm_domain *genpd,
+ struct device *dev)
{
return GENPD_DEV_CALLBACK(genpd, int, start, dev);
}
@@ -738,7 +740,7 @@ static bool pm_genpd_present(const struct generic_pm_domain *genpd)
#ifdef CONFIG_PM_SLEEP
-static bool genpd_dev_active_wakeup(struct generic_pm_domain *genpd,
+static bool genpd_dev_active_wakeup(const struct generic_pm_domain *genpd,
struct device *dev)
{
return GENPD_DEV_CALLBACK(genpd, bool, active_wakeup, dev);
@@ -840,7 +842,8 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,
* signal remote wakeup from the system's working state as needed by runtime PM.
* Return 'true' in either of the above cases.
*/
-static bool resume_needed(struct device *dev, struct generic_pm_domain *genpd)
+static bool resume_needed(struct device *dev,
+ const struct generic_pm_domain *genpd)
{
bool active_wakeup;
@@ -975,7 +978,7 @@ static int pm_genpd_resume_noirq(struct device *dev)
*/
static int pm_genpd_freeze_noirq(struct device *dev)
{
- struct generic_pm_domain *genpd;
+ const struct generic_pm_domain *genpd;
int ret = 0;
dev_dbg(dev, "%s()\n", __func__);
@@ -999,7 +1002,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)
*/
static int pm_genpd_thaw_noirq(struct device *dev)
{
- struct generic_pm_domain *genpd;
+ const struct generic_pm_domain *genpd;
int ret = 0;
dev_dbg(dev, "%s()\n", __func__);
--
2.9.3
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2017-06-13 12:40 +0200 |
| Message-ID | <tRRoS-6Pq-21@gated-at.bofh.it> |
| In reply to | #1663593 |
On 12 June 2017 at 17:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Mark pointer to struct generic_pm_domain const (either passed in
> argument or used localy in a function), whenever it is not modifed by
> the function itself.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/base/power/domain.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index da49a8383dc3..2e8d0f423507 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -126,7 +126,7 @@ static const struct genpd_lock_ops genpd_spin_ops = {
> #define genpd_is_always_on(genpd) (genpd->flags & GENPD_FLAG_ALWAYS_ON)
>
> static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev,
> - struct generic_pm_domain *genpd)
> + const struct generic_pm_domain *genpd)
> {
> bool ret;
>
> @@ -181,12 +181,14 @@ static struct generic_pm_domain *dev_to_genpd(struct device *dev)
> return pd_to_genpd(dev->pm_domain);
> }
>
> -static int genpd_stop_dev(struct generic_pm_domain *genpd, struct device *dev)
> +static int genpd_stop_dev(const struct generic_pm_domain *genpd,
> + struct device *dev)
> {
> return GENPD_DEV_CALLBACK(genpd, int, stop, dev);
> }
>
> -static int genpd_start_dev(struct generic_pm_domain *genpd, struct device *dev)
> +static int genpd_start_dev(const struct generic_pm_domain *genpd,
> + struct device *dev)
> {
> return GENPD_DEV_CALLBACK(genpd, int, start, dev);
> }
> @@ -738,7 +740,7 @@ static bool pm_genpd_present(const struct generic_pm_domain *genpd)
>
> #ifdef CONFIG_PM_SLEEP
>
> -static bool genpd_dev_active_wakeup(struct generic_pm_domain *genpd,
> +static bool genpd_dev_active_wakeup(const struct generic_pm_domain *genpd,
> struct device *dev)
> {
> return GENPD_DEV_CALLBACK(genpd, bool, active_wakeup, dev);
> @@ -840,7 +842,8 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,
> * signal remote wakeup from the system's working state as needed by runtime PM.
> * Return 'true' in either of the above cases.
> */
> -static bool resume_needed(struct device *dev, struct generic_pm_domain *genpd)
> +static bool resume_needed(struct device *dev,
> + const struct generic_pm_domain *genpd)
> {
> bool active_wakeup;
>
> @@ -975,7 +978,7 @@ static int pm_genpd_resume_noirq(struct device *dev)
> */
> static int pm_genpd_freeze_noirq(struct device *dev)
> {
> - struct generic_pm_domain *genpd;
> + const struct generic_pm_domain *genpd;
> int ret = 0;
>
> dev_dbg(dev, "%s()\n", __func__);
> @@ -999,7 +1002,7 @@ static int pm_genpd_freeze_noirq(struct device *dev)
> */
> static int pm_genpd_thaw_noirq(struct device *dev)
> {
> - struct generic_pm_domain *genpd;
> + const struct generic_pm_domain *genpd;
> int ret = 0;
>
> dev_dbg(dev, "%s()\n", __func__);
> --
> 2.9.3
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web