Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662695 > unrolled thread

[PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Started bysrishti sharma <srishtishar@gmail.com>
First post2017-06-09 21:00 +0200
Last post2017-06-12 15:20 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-09 21:00 +0200
    Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match  open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-09 21:10 +0200
      Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match  open parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-12 14:30 +0200
        Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match  open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-12 14:50 +0200
          Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match  open parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-12 15:20 +0200
            Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match  open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-12 15:20 +0200

#1662695 — [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-09 21:00 +0200
Subject[PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tQxiy-59d-27@gated-at.bofh.it>
Fixed alignment so that it matched open paranthesis .

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 697347b..e3c11be 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)

 static
 void hostif_power_mgmt_request(struct ks_wlan_private *priv,
-				unsigned long mode, unsigned long wake_up,
-				unsigned long receive_dtims)
+			       unsigned long mode, unsigned long wake_up,
+			       unsigned long receive_dtims)
 {
	struct hostif_power_mgmt_request_t *pp;

--
2.7.4

[toc] | [next] | [standalone]

#1662699 — Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-09 21:10 +0200
SubjectRe: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tQxse-5ru-21@gated-at.bofh.it>
In reply to#1662695
On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <srishtishar@gmail.com> wrote:
> Fixed alignment so that it matched open paranthesis .
>
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 697347b..e3c11be 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
>
>  static
>  void hostif_power_mgmt_request(struct ks_wlan_private *priv,
> -                               unsigned long mode, unsigned long wake_up,
> -                               unsigned long receive_dtims)
> +                              unsigned long mode, unsigned long wake_up,
> +                              unsigned long receive_dtims)
>  {
>         struct hostif_power_mgmt_request_t *pp;
>
> --
> 2.7.4

Okay , this doesn't look right , please ignore ! Sorry

Thanks
Srishti

[toc] | [prev] | [next] | [standalone]

#1663463 — Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

FromDan Carpenter <dan.carpenter@oracle.com>
Date2017-06-12 14:30 +0200
SubjectRe: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tRwDM-22k-7@gated-at.bofh.it>
In reply to#1662699
On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <srishtishar@gmail.com> wrote:
> > Fixed alignment so that it matched open paranthesis .
> >
> > Signed-off-by: srishti sharma <srishtishar@gmail.com>
                   ^       ^

You're the opposite of me.  My mama named me with capital letters but
informally I sometimes use lower case.  Your formal name is lower case
but informally you use caps.  :P

> 
> Okay , this doesn't look right , please ignore ! Sorry
> 

It actually is correct, it just looks wrong in the diff because of the
extra " +-" character at the beginning of the line.

> Thanks
> Srishti

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1663479 — Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-12 14:50 +0200
SubjectRe: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tRwX8-2bL-23@gated-at.bofh.it>
In reply to#1663463
On Mon, Jun 12, 2017 at 5:53 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
>> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <srishtishar@gmail.com> wrote:
>> > Fixed alignment so that it matched open paranthesis .
>> >
>> > Signed-off-by: srishti sharma <srishtishar@gmail.com>
>                    ^       ^
>
> You're the opposite of me.  My mama named me with capital letters but
> informally I sometimes use lower case.  Your formal name is lower case
> but informally you use caps.  :P
>
>>
>> Okay , this doesn't look right , please ignore ! Sorry
>>
>
> It actually is correct, it just looks wrong in the diff because of the
> extra " +-" character at the beginning of the line.
>
>> Thanks
>> Srishti
>
> regards,
> dan carpenter
>


Hey,

Thanks :) , so will this be accepted ?

Regards,
Srishti

[toc] | [prev] | [next] | [standalone]

#1663493 — Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

FromDan Carpenter <dan.carpenter@oracle.com>
Date2017-06-12 15:20 +0200
SubjectRe: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tRxqa-2AI-3@gated-at.bofh.it>
In reply to#1663479
On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
> 
> Thanks :) , so will this be accepted ?
> 

Probably, yes.  Unless Greg has already dropped it because you said to
drop it.

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1663501 — Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fromsrishti sharma <srishtishar@gmail.com>
Date2017-06-12 15:20 +0200
SubjectRe: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis
Message-ID<tRxqa-2AI-21@gated-at.bofh.it>
In reply to#1663493
On Mon, Jun 12, 2017 at 6:47 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
>>
>> Thanks :) , so will this be accepted ?
>>
>
> Probably, yes.  Unless Greg has already dropped it because you said to
> drop it.
>
> regards,
> dan carpenter
>


Okay, Thanks :)

Regards,
srishti

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web