Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663251 > unrolled thread
| Started by | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| First post | 2017-06-12 08:00 +0200 |
| Last post | 2017-06-12 10:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-12 08:00 +0200
Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove Lee Jones <lee.jones@linaro.org> - 2017-06-12 10:20 +0200
Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove jeffy <jeffy.chen@rock-chips.com> - 2017-06-12 10:50 +0200
| From | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-06-12 08:00 +0200 |
| Subject | [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove |
| Message-ID | <tRqyl-6zn-3@gated-at.bofh.it> |
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- drivers/mfd/cros_ec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index e31ac60..dc6ce90 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) cros_ec_acpi_remove_gpe_handler(); + if (ec_dev->irq) + free_irq(ec_dev->irq, ec_dev); + return 0; } EXPORT_SYMBOL(cros_ec_remove); -- 2.1.4
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-06-12 10:20 +0200 |
| Message-ID | <tRsJP-86G-5@gated-at.bofh.it> |
| In reply to | #1663251 |
mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature. Also, you should populate the commit log with what are you doing and why is it required. > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > > --- > > drivers/mfd/cros_ec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index e31ac60..dc6ce90 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) > > cros_ec_acpi_remove_gpe_handler(); > > + if (ec_dev->irq) > + free_irq(ec_dev->irq, ec_dev); > + > return 0; > } > EXPORT_SYMBOL(cros_ec_remove); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-06-12 10:50 +0200 |
| Message-ID | <tRtcS-8iy-17@gated-at.bofh.it> |
| In reply to | #1663304 |
Hi Lee, On 06/12/2017 04:17 PM, Lee Jones wrote: > mfd: cros_ec: Add missing free_irq in cros_ec_remove > > It would be better to use more English and less code in the patch's > subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on > exit". Something of that nature. > > Also, you should populate the commit log with what are you doing and > why is it required. oh, right, thanks for your comment, i'll rewrite it :) > >> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> >> >> --- >> >> drivers/mfd/cros_ec.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c >> index e31ac60..dc6ce90 100644 >> --- a/drivers/mfd/cros_ec.c >> +++ b/drivers/mfd/cros_ec.c >> @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) >> >> cros_ec_acpi_remove_gpe_handler(); >> >> + if (ec_dev->irq) >> + free_irq(ec_dev->irq, ec_dev); >> + >> return 0; >> } >> EXPORT_SYMBOL(cros_ec_remove); >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web