Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1663265 > unrolled thread

[PATCH] watchdog: zx2967: constify zx2967_wdt_ops.

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-06-12 08:40 +0200
Last post2017-06-15 19:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] watchdog: zx2967: constify zx2967_wdt_ops. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-12 08:40 +0200
    Re: [PATCH] watchdog: zx2967: constify zx2967_wdt_ops. Guenter Roeck <linux@roeck-us.net> - 2017-06-15 19:30 +0200

#1663265 — [PATCH] watchdog: zx2967: constify zx2967_wdt_ops.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-06-12 08:40 +0200
Subject[PATCH] watchdog: zx2967: constify zx2967_wdt_ops.
Message-ID<tRrb3-72G-3@gated-at.bofh.it>
File size before:
   text	   data	    bss	    dec	    hex	filename
    988	    288	      0	   1276	    4fc	drivers/watchdog/zx2967_wdt.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   1084	    192	      0	   1276	    4fc	drivers/watchdog/zx2967_wdt.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/watchdog/zx2967_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
index e290d5a..17774de 100644
--- a/drivers/watchdog/zx2967_wdt.c
+++ b/drivers/watchdog/zx2967_wdt.c
@@ -154,7 +154,7 @@ static int zx2967_wdt_keepalive(struct watchdog_device *wdd)
 	.identity         =	"zx2967 watchdog",
 };
 
-static struct watchdog_ops zx2967_wdt_ops = {
+static const struct watchdog_ops zx2967_wdt_ops = {
 	.owner = THIS_MODULE,
 	.start = zx2967_wdt_start,
 	.stop = zx2967_wdt_stop,
-- 
1.9.1

[toc] | [next] | [standalone]


#1666920

FromGuenter Roeck <linux@roeck-us.net>
Date2017-06-15 19:30 +0200
Message-ID<tSGKK-5iA-15@gated-at.bofh.it>
In reply to#1663265
On Mon, Jun 12, 2017 at 12:02:39PM +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     988	    288	      0	   1276	    4fc	drivers/watchdog/zx2967_wdt.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    1084	    192	      0	   1276	    4fc	drivers/watchdog/zx2967_wdt.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/zx2967_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
> index e290d5a..17774de 100644
> --- a/drivers/watchdog/zx2967_wdt.c
> +++ b/drivers/watchdog/zx2967_wdt.c
> @@ -154,7 +154,7 @@ static int zx2967_wdt_keepalive(struct watchdog_device *wdd)
>  	.identity         =	"zx2967 watchdog",
>  };
>  
> -static struct watchdog_ops zx2967_wdt_ops = {
> +static const struct watchdog_ops zx2967_wdt_ops = {
>  	.owner = THIS_MODULE,
>  	.start = zx2967_wdt_start,
>  	.stop = zx2967_wdt_stop,
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web