Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663192 > unrolled thread
| Started by | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| First post | 2017-06-12 04:20 +0200 |
| Last post | 2017-06-12 22:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] pci: endpoint: fix endpoint test build error Randy Dunlap <rdunlap@infradead.org> - 2017-06-12 04:20 +0200
Re: [PATCH] pci: endpoint: fix endpoint test build error Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-12 10:40 +0200
Re: [PATCH] pci: endpoint: fix endpoint test build error Bjorn Helgaas <helgaas@kernel.org> - 2017-06-12 22:50 +0200
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-06-12 04:20 +0200 |
| Subject | [PATCH] pci: endpoint: fix endpoint test build error |
| Message-ID | <tRn7r-4AB-3@gated-at.bofh.it> |
From: Randy Dunlap <rdunlap@infradead.org> PCI endpoint test driver uses crc32_le() so it should select CRC32. Fixes this build error (when CRC32=m): drivers/built-in.o: In function `pci_epf_test_cmd_handler': pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le' Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI). Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Kishon Vijay Abraham I <kishon@ti.com> Cc: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/endpoint/functions/Kconfig | 1 + 1 file changed, 1 insertion(+) --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig @@ -5,6 +5,7 @@ config PCI_EPF_TEST tristate "PCI Endpoint Test driver" depends on PCI_ENDPOINT + select CRC32 help Enable this configuration option to enable the test driver for PCI Endpoint.
[toc] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-06-12 10:40 +0200 |
| Message-ID | <tRt3c-8fc-17@gated-at.bofh.it> |
| In reply to | #1663192 |
On Monday 12 June 2017 07:40 AM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > PCI endpoint test driver uses crc32_le() so it should select > CRC32. Fixes this build error (when CRC32=m): > > drivers/built-in.o: In function `pci_epf_test_cmd_handler': > pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le' > > Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI). > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/pci/endpoint/functions/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig > +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig > @@ -5,6 +5,7 @@ > config PCI_EPF_TEST > tristate "PCI Endpoint Test driver" > depends on PCI_ENDPOINT > + select CRC32 > help > Enable this configuration option to enable the test driver > for PCI Endpoint. > >
[toc] | [prev] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2017-06-12 22:50 +0200 |
| Message-ID | <tRErD-74t-1@gated-at.bofh.it> |
| In reply to | #1663192 |
On Sun, Jun 11, 2017 at 07:10:38PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > PCI endpoint test driver uses crc32_le() so it should select > CRC32. Fixes this build error (when CRC32=m): > > drivers/built-in.o: In function `pci_epf_test_cmd_handler': > pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le' > > Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI). > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Applied with Kishon's ack to for-linus for v4.12 (since 349e7a85b25f first appeared in v4.12-rc1), thanks! > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/pci/endpoint/functions/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig > +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig > @@ -5,6 +5,7 @@ > config PCI_EPF_TEST > tristate "PCI Endpoint Test driver" > depends on PCI_ENDPOINT > + select CRC32 > help > Enable this configuration option to enable the test driver > for PCI Endpoint. > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web