Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664875 > unrolled thread

[PATCH 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

Started byMichał Mirosław <mirq-linux@rere.qmqm.pl>
First post2017-06-13 16:00 +0200
Last post2017-06-13 19:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] regulator: include 'enabled' status in  debugfs/regulator_summary Michał Mirosław <mirq-linux@rere.qmqm.pl> - 2017-06-13 16:00 +0200
    [PATCH 2/2] regulator: use consumer->supply_name in  debugfs/regulator_summary Michał Mirosław <mirq-linux@rere.qmqm.pl> - 2017-06-13 16:00 +0200
    [PATCH v2 1/2] regulator: include 'enabled' status in  debugfs/regulator_summary Michał Mirosław <mirq-linux@rere.qmqm.pl> - 2017-06-13 17:00 +0200
      Re: [PATCH v2 1/2] regulator: include 'enabled' status in  debugfs/regulator_summary Mark Brown <broonie@kernel.org> - 2017-06-13 19:50 +0200

#1664875 — [PATCH 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

FromMichał Mirosław <mirq-linux@rere.qmqm.pl>
Date2017-06-13 16:00 +0200
Subject[PATCH 1/2] regulator: include 'enabled' status in debugfs/regulator_summary
Message-ID<tRUwp-dH-1@gated-at.bofh.it>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/regulator/core.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8d0860e..ba4d121ae07fc 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4379,13 +4379,18 @@ static void regulator_summary_show_subtree(struct seq_file *s,
 	struct regulation_constraints *c;
 	struct regulator *consumer;
 	struct summary_data summary_data;
+	int is_enabled;
 
 	if (!rdev)
 		return;
 
-	seq_printf(s, "%*s%-*s %3d %4d %6d ",
+	mutex_lock(&rdev->mutex);
+	is_enabled = _regulator_is_enabled(rdev);
+	mutex_unlock(&rdev->mutex);
+
+	seq_printf(s, "%*s%-*s %3d %3d %4d %6d ",
 		   level * 3 + 1, "",
-		   30 - level * 3, rdev_get_name(rdev),
+		   30 - level * 3, rdev_get_name(rdev), is_enabled,
 		   rdev->use_count, rdev->open_count, rdev->bypass_count);
 
 	seq_printf(s, "%5dmV ", _regulator_get_voltage(rdev) / 1000);
@@ -4450,8 +4455,8 @@ static int regulator_summary_show_roots(struct device *dev, void *data)
 
 static int regulator_summary_show(struct seq_file *s, void *data)
 {
-	seq_puts(s, " regulator                      use open bypass voltage current     min     max\n");
-	seq_puts(s, "-------------------------------------------------------------------------------\n");
+	seq_puts(s, " regulator                      ena use open bypass voltage current     min     max\n");
+	seq_puts(s, "-----------------------------------------------------------------------------------\n");
 
 	class_for_each_device(&regulator_class, NULL, s,
 			      regulator_summary_show_roots);
-- 
2.11.0

[toc] | [next] | [standalone]

#1664886 — [PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary

FromMichał Mirosław <mirq-linux@rere.qmqm.pl>
Date2017-06-13 16:00 +0200
Subject[PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary
Message-ID<tRUwq-dH-23@gated-at.bofh.it>
In reply to#1664875
Before:

 regulator                      ena use open bypass voltage current min     max
-----------------------------------------------------------------------------------
 regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
    1-0010                                                          0mV     0mV
    1-0010                                                          0mV     0mV

After:

 regulator                      ena use open bypass voltage current min     max
-----------------------------------------------------------------------------------
 regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
    1-0010-vccio                                                    0mV     0mV
    1-0010-vcc33                                                    0mV     0mV

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/regulator/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index ba4d121ae07fc..a9bfabd132cff 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4419,6 +4419,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
 		seq_printf(s, "%*s%-*s ",
 			   (level + 1) * 3 + 1, "",
 			   30 - (level + 1) * 3,
+			   consumer->supply_name ? consumer->supply_name :
 			   consumer->dev ? dev_name(consumer->dev) : "deviceless");
 
 		switch (rdev->desc->type) {
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1664953 — [PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

FromMichał Mirosław <mirq-linux@rere.qmqm.pl>
Date2017-06-13 17:00 +0200
Subject[PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary
Message-ID<tRVst-Oa-5@gated-at.bofh.it>
In reply to#1664875
Extend regulator's info line with enabled/disabled status.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
v2:
  - include commit message

 drivers/regulator/core.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8d0860e..ba4d121ae07fc 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -4379,13 +4379,18 @@ static void regulator_summary_show_subtree(struct seq_file *s,
 	struct regulation_constraints *c;
 	struct regulator *consumer;
 	struct summary_data summary_data;
+	int is_enabled;
 
 	if (!rdev)
 		return;
 
-	seq_printf(s, "%*s%-*s %3d %4d %6d ",
+	mutex_lock(&rdev->mutex);
+	is_enabled = _regulator_is_enabled(rdev);
+	mutex_unlock(&rdev->mutex);
+
+	seq_printf(s, "%*s%-*s %3d %3d %4d %6d ",
 		   level * 3 + 1, "",
-		   30 - level * 3, rdev_get_name(rdev),
+		   30 - level * 3, rdev_get_name(rdev), is_enabled,
 		   rdev->use_count, rdev->open_count, rdev->bypass_count);
 
 	seq_printf(s, "%5dmV ", _regulator_get_voltage(rdev) / 1000);
@@ -4450,8 +4455,8 @@ static int regulator_summary_show_roots(struct device *dev, void *data)
 
 static int regulator_summary_show(struct seq_file *s, void *data)
 {
-	seq_puts(s, " regulator                      use open bypass voltage current     min     max\n");
-	seq_puts(s, "-------------------------------------------------------------------------------\n");
+	seq_puts(s, " regulator                      ena use open bypass voltage current     min     max\n");
+	seq_puts(s, "-----------------------------------------------------------------------------------\n");
 
 	class_for_each_device(&regulator_class, NULL, s,
 			      regulator_summary_show_roots);
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1665060 — Re: [PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

FromMark Brown <broonie@kernel.org>
Date2017-06-13 19:50 +0200
SubjectRe: [PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary
Message-ID<tRY70-2tP-19@gated-at.bofh.it>
In reply to#1664953

[Multipart message — attachments visible in raw view] — view raw

On Tue, Jun 13, 2017 at 04:50:35PM +0200, Michał Mirosław wrote:
> Extend regulator's info line with enabled/disabled status.

Like I say please don't send new patches in reply to old ones - I can't
tell what's going on here, I've got this mail but no v2 to go with it?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web