Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664869 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-13 15:50 +0200 |
| Last post | 2017-06-15 15:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Colin King <colin.king@canonical.com> - 2017-06-13 15:50 +0200
Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> - 2017-06-14 15:10 +0200
Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-06-15 15:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-13 15:50 +0200 |
| Subject | [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static |
| Message-ID | <tRUmK-ap-43@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global
scope, so make it static.
Cleans up sparse warning:
"symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it
be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 8e669b6254ae..2f7b0e64f628 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
return true;
}
-bool cnl_ddi_dp_set_dpll_hw_state(int clock,
- struct intel_dpll_hw_state *dpll_hw_state)
+static bool
+cnl_ddi_dp_set_dpll_hw_state(int clock,
+ struct intel_dpll_hw_state *dpll_hw_state)
{
uint32_t cfgcr0;
--
2.11.0
[toc] | [next] | [standalone]
| From | Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> |
|---|---|
| Date | 2017-06-14 15:10 +0200 |
| Subject | Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static |
| Message-ID | <tSgdz-5BT-17@gated-at.bofh.it> |
| In reply to | #1664869 |
On 13/06/2017 14:47, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global
> scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it
> be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 8e669b6254ae..2f7b0e64f628 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
> return true;
> }
>
> -bool cnl_ddi_dp_set_dpll_hw_state(int clock,
> - struct intel_dpll_hw_state *dpll_hw_state)
> +static bool
> +cnl_ddi_dp_set_dpll_hw_state(int clock,
> + struct intel_dpll_hw_state *dpll_hw_state)
> {
> uint32_t cfgcr0;
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
[toc] | [prev] | [next] | [standalone]
| From | Ville Syrjälä <ville.syrjala@linux.intel.com> |
|---|---|
| Date | 2017-06-15 15:20 +0200 |
| Subject | Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static |
| Message-ID | <tSCQO-2X8-13@gated-at.bofh.it> |
| In reply to | #1665803 |
On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote:
>
> On 13/06/2017 14:47, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global
> > scope, so make it static.
> >
> > Cleans up sparse warning:
> > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it
> > be static?"
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > index 8e669b6254ae..2f7b0e64f628 100644
> > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
> > return true;
> > }
> >
> > -bool cnl_ddi_dp_set_dpll_hw_state(int clock,
> > - struct intel_dpll_hw_state *dpll_hw_state)
> > +static bool
> > +cnl_ddi_dp_set_dpll_hw_state(int clock,
> > + struct intel_dpll_hw_state *dpll_hw_state)
> > {
> > uint32_t cfgcr0;
> >
> >
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Thanks for the patch and review. Pushed to dinq.
--
Ville Syrjälä
Intel OTC
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web