Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663595 > unrolled thread

[PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-12 17:20 +0200
    Re: [PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-13 12:40 +0200

#1663595 — [PATCH v2 7/8] PM / Domains: Fix missing default_power_down_ok comment

Commit fc5cbf0c94b6 ("PM / Domains: Support for multiple states") split
out some code out of default_power_down_ok() function so the
documentation has to be moved to appropriate place.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/base/power/domain_governor.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
index 2e0fce711135..281f949c5ffe 100644
--- a/drivers/base/power/domain_governor.c
+++ b/drivers/base/power/domain_governor.c
@@ -92,12 +92,6 @@ static bool default_suspend_ok(struct device *dev)
 	return td->cached_suspend_ok;
 }
 
-/**
- * default_power_down_ok - Default generic PM domain power off governor routine.
- * @pd: PM domain to check.
- *
- * This routine must be executed under the PM domain's lock.
- */
 static bool __default_power_down_ok(struct dev_pm_domain *pd,
 				     unsigned int state)
 {
@@ -187,6 +181,12 @@ static bool __default_power_down_ok(struct dev_pm_domain *pd,
 	return true;
 }
 
+/**
+ * default_power_down_ok - Default generic PM domain power off governor routine.
+ * @pd: PM domain to check.
+ *
+ * This routine must be executed under the PM domain's lock.
+ */
 static bool default_power_down_ok(struct dev_pm_domain *pd)
 {
 	struct generic_pm_domain *genpd = pd_to_genpd(pd);
-- 
2.9.3

[toc] | [next] | [standalone]

#1664737

On 12 June 2017 at 17:17, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Commit fc5cbf0c94b6 ("PM / Domains: Support for multiple states") split
> out some code out of default_power_down_ok() function so the
> documentation has to be moved to appropriate place.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
>  drivers/base/power/domain_governor.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
> index 2e0fce711135..281f949c5ffe 100644
> --- a/drivers/base/power/domain_governor.c
> +++ b/drivers/base/power/domain_governor.c
> @@ -92,12 +92,6 @@ static bool default_suspend_ok(struct device *dev)
>         return td->cached_suspend_ok;
>  }
>
> -/**
> - * default_power_down_ok - Default generic PM domain power off governor routine.
> - * @pd: PM domain to check.
> - *
> - * This routine must be executed under the PM domain's lock.
> - */
>  static bool __default_power_down_ok(struct dev_pm_domain *pd,
>                                      unsigned int state)
>  {
> @@ -187,6 +181,12 @@ static bool __default_power_down_ok(struct dev_pm_domain *pd,
>         return true;
>  }
>
> +/**
> + * default_power_down_ok - Default generic PM domain power off governor routine.
> + * @pd: PM domain to check.
> + *
> + * This routine must be executed under the PM domain's lock.
> + */
>  static bool default_power_down_ok(struct dev_pm_domain *pd)
>  {
>         struct generic_pm_domain *genpd = pd_to_genpd(pd);
> --
> 2.9.3
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web