Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664734 > unrolled thread

Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-13 12:40 +0200
    Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing Rob Herring <robh+dt@kernel.org> - 2017-06-13 23:00 +0200

#1664734 — Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing

On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
> but of_device_compatible_match() hasn't.  Fix that to improve the
> ability to do compile-testing.
>
> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Any reason not to apply this patch?

Thanks!

> ---
>  include/linux/of.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 21e6323de0f3b786..bfd1a23221735161 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -620,6 +620,12 @@ static inline int of_device_is_compatible(const struct device_node *device,
>         return 0;
>  }
>
> +static inline  int of_device_compatible_match(struct device_node *device,
> +                                             const char *const *compat)
> +{
> +       return 0;
> +}
> +
>  static inline bool of_device_is_available(const struct device_node *device)
>  {
>         return false;
> --
> 2.7.4

[toc] | [next] | [standalone]

#1665184

On Tue, Jun 13, 2017 at 5:32 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
>> but of_device_compatible_match() hasn't.  Fix that to improve the
>> ability to do compile-testing.
>>
>> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Any reason not to apply this patch?

No, sorry I missed it. I've queued it up for 4.13.

Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web