Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664749 > unrolled thread

Re: [PATCH 3/3] livepatch: add shadow variable sample program

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/3] livepatch: add shadow variable sample program Miroslav Benes <mbenes@suse.cz> - 2017-06-13 13:10 +0200
    Re: [PATCH 3/3] livepatch: add shadow variable sample program Joe Lawrence <joe.lawrence@redhat.com> - 2017-06-13 19:40 +0200
      Re: [PATCH 3/3] livepatch: add shadow variable sample program Miroslav Benes <mbenes@suse.cz> - 2017-06-14 09:50 +0200

#1664749 — Re: [PATCH 3/3] livepatch: add shadow variable sample program

On Thu, 1 Jun 2017, Joe Lawrence wrote:

> Modify the sample livepatch to demonstrate the shadow variable API.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
>  samples/livepatch/livepatch-sample.c | 39 +++++++++++++++++++++++++++++++++++-
>  1 file changed, 38 insertions(+), 1 deletion(-)

Would it make sense to make this our second sample module? I think we 
should keep one as simple as possible, and illustrate new features in 
separate sample modules.

I'd like to have another one for klp-convert patch set too.

What do you think?

Miroslav

[toc] | [next] | [standalone]

#1665050

On 06/13/2017 07:00 AM, Miroslav Benes wrote:
> On Thu, 1 Jun 2017, Joe Lawrence wrote:
> 
>> Modify the sample livepatch to demonstrate the shadow variable API.
>>
>> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
>> ---
>>  samples/livepatch/livepatch-sample.c | 39 +++++++++++++++++++++++++++++++++++-
>>  1 file changed, 38 insertions(+), 1 deletion(-)
> 
> Would it make sense to make this our second sample module? I think we 
> should keep one as simple as possible, and illustrate new features in 
> separate sample modules.
> 
> I'd like to have another one for klp-convert patch set too.
> 
> What do you think?
> 
> Miroslav
> 

Yeah, adding this as a new sample module is a good idea.  I'll split
that out in v2.

I'm not familiar with klp-convert, so I'll assume that will be handled
as its own patch(set).

Thanks,

-- Joe

[toc] | [prev] | [next] | [standalone]

#1665530

> I'm not familiar with klp-convert, so I'll assume that will be handled
> as its own patch(set).

Correct.

Miroslav

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web