Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664059 > unrolled thread

[PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition

Started byJérémy Lefaure <jeremy.lefaure@lse.epita.fr>
First post2017-06-12 19:20 +0200
Last post2017-06-13 09:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition Jérémy Lefaure          <jeremy.lefaure@lse.epita.fr> - 2017-06-12 19:20 +0200
    Re: [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-13 09:40 +0200

#1664059 — [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition

FromJérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Date2017-06-12 19:20 +0200
Subject[PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
Message-ID<tRBaq-4Z3-23@gated-at.bofh.it>
I didn't find any use of this macro in the current kernel tree (with git
grep). KTHREAD_SIZE is no longer used for a very very long time. So
let's remove this definition.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 arch/arm/include/asm/page-nommu.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
index 503f488053de..8f2c47bec375 100644
--- a/arch/arm/include/asm/page-nommu.h
+++ b/arch/arm/include/asm/page-nommu.h
@@ -11,12 +11,6 @@
 #ifndef _ASMARM_PAGE_NOMMU_H
 #define _ASMARM_PAGE_NOMMU_H
 
-#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
-#define KTHREAD_SIZE (8192)
-#else
-#define KTHREAD_SIZE PAGE_SIZE
-#endif
- 
 #define clear_page(page)	memset((page), 0, PAGE_SIZE)
 #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
 
-- 
2.13.1

[toc] | [next] | [standalone]


#1664555

FromVladimir Murzin <vladimir.murzin@arm.com>
Date2017-06-13 09:40 +0200
Message-ID<tROAG-54W-19@gated-at.bofh.it>
In reply to#1664059
On 12/06/17 18:09, Jérémy Lefaure wrote:
> I didn't find any use of this macro in the current kernel tree (with git
> grep). KTHREAD_SIZE is no longer used for a very very long time. So
> let's remove this definition.
> 
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
>  arch/arm/include/asm/page-nommu.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
> index 503f488053de..8f2c47bec375 100644
> --- a/arch/arm/include/asm/page-nommu.h
> +++ b/arch/arm/include/asm/page-nommu.h
> @@ -11,12 +11,6 @@
>  #ifndef _ASMARM_PAGE_NOMMU_H
>  #define _ASMARM_PAGE_NOMMU_H
>  
> -#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
> -#define KTHREAD_SIZE (8192)
> -#else
> -#define KTHREAD_SIZE PAGE_SIZE
> -#endif
> - 
>  #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>  #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
>  
> 

Even more, CONFIG_SMALL_TASKS has gone and only page size we support is 4K.

It looks like that similar patch has been submitted several times by different
people but never got merged, so if it helps:

Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>

Cheers
Vladimir

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web