Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1661333 > unrolled thread
| Started by | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| First post | 2017-06-08 16:40 +0200 |
| Last post | 2017-06-11 12:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH] regmap: make LZO cache optional Andreas Ziegler <andreas.ziegler@fau.de> - 2017-06-08 16:40 +0200
Re: [PATCH] regmap: make LZO cache optional Jonas Gorski <jonas.gorski@gmail.com> - 2017-06-11 12:30 +0200
| From | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| Date | 2017-06-08 16:40 +0200 |
| Subject | Re: [PATCH] regmap: make LZO cache optional |
| Message-ID | <tQ6Ln-5sD-1@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi Jonas, I noticed your patch 'regmap: make LZO cache optional' as it recently showed up in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by adding an #if IS_ENABLED() statement. However, this statement contains a spelling error, as it references REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H). I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7' As Greg suggested the whole code could be dropped, this might not be too relevant, but I wanted to let you know in any case. Best regards, Andreas
[toc] | [next] | [standalone]
| From | Jonas Gorski <jonas.gorski@gmail.com> |
|---|---|
| Date | 2017-06-11 12:30 +0200 |
| Message-ID | <tR8i6-3Qh-3@gated-at.bofh.it> |
| In reply to | #1661333 |
Hi Andreas, On 8 June 2017 at 16:28, Andreas Ziegler <andreas.ziegler@fau.de> wrote: > Hi Jonas, > > I noticed your patch 'regmap: make LZO cache optional' as it recently showed up > in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by > adding an #if IS_ENABLED() statement. > > However, this statement contains a spelling error, as it references > REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H). > > I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on > the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7' > > As Greg suggested the whole code could be dropped, this might not be too > relevant, but I wanted to let you know in any case. Thanks for spotting that, and I wasn't aware of this script, that seems quite useful! Regards Jonas
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web