Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663049 > unrolled thread
| Started by | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| First post | 2017-06-11 08:20 +0200 |
| Last post | 2017-06-11 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-11 08:20 +0200
Re: [PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues' walter harms <wharms@bfs.de> - 2017-06-11 10:40 +0200
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Date | 2017-06-11 08:20 +0200 |
| Subject | [PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues' |
| Message-ID | <tR4o9-1x7-1@gated-at.bofh.it> |
We should return -ENOMEM in case of memory allocation error, as done
elsewhere in this function.
Fixes: 61d8658b4a435 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/scsi/qedf/qedf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index aab3e2bd26a0..52a27100ca6d 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2673,6 +2673,7 @@ static int qedf_alloc_global_queues(struct qedf_ctx *qedf)
if (!qedf->global_queues[i]) {
QEDF_WARN(&(qedf->dbg_ctx), "Unable to allocation "
"global queue %d.\n", i);
+ status = -ENOMEM;
goto mem_alloc_failure;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | walter harms <wharms@bfs.de> |
|---|---|
| Date | 2017-06-11 10:40 +0200 |
| Subject | Re: [PATCH 1/3] scsi: qedf: Fix a return value in case of error in 'qedf_alloc_global_queues' |
| Message-ID | <tR6zD-2MF-11@gated-at.bofh.it> |
| In reply to | #1663049 |
Am 11.06.2017 08:16, schrieb Christophe JAILLET:
> We should return -ENOMEM in case of memory allocation error, as done
> elsewhere in this function.
>
> Fixes: 61d8658b4a435 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/scsi/qedf/qedf_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index aab3e2bd26a0..52a27100ca6d 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2673,6 +2673,7 @@ static int qedf_alloc_global_queues(struct qedf_ctx *qedf)
> if (!qedf->global_queues[i]) {
> QEDF_WARN(&(qedf->dbg_ctx), "Unable to allocation "
> "global queue %d.\n", i);
> + status = -ENOMEM;
> goto mem_alloc_failure;
> }
>
I am not native english but the error msg sounds strange ...
re,
wh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web