Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662285 > unrolled thread
| Started by | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| First post | 2017-06-09 13:00 +0200 |
| Last post | 2017-06-09 13:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-06-09 13:00 +0200
Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-06-09 13:40 +0200
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-06-09 13:00 +0200 |
| Subject | Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable |
| Message-ID | <tQpO1-tE-7@gated-at.bofh.it> |
On Fri, 9 Jun 2017 12:47:43 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> This one was accidentally introduced without any references,
> and it causes a harmless warning:
>
> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>
> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
If you don't mind, I'll squash the change in the initial commit.
Thanks,
Boris
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index 14ef2f4524ac..d1c4538f870f 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -693,8 +693,6 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
> if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER) {
> - int res;
> -
> if (!oob_required)
> fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
>
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-09 13:40 +0200 |
| Message-ID | <tQqqK-V3-13@gated-at.bofh.it> |
| In reply to | #1662285 |
On Fri, Jun 9, 2017 at 12:56 PM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Fri, 9 Jun 2017 12:47:43 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
>> This one was accidentally introduced without any references,
>> and it causes a harmless warning:
>>
>> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
>> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>>
>> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> If you don't mind, I'll squash the change in the initial commit.
Sure, that's always the best way to do it when the commits are not yet stable.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web