Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1661985 > unrolled thread

[REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

Started byRalph Sennhauser <ralph.sennhauser@gmail.com>
First post2017-06-09 09:00 +0200
Last post2017-06-09 12:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio:  mvebu: switch to regmap for register access") Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 09:00 +0200
    Re: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access") Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-06-09 12:20 +0200

#1661985 — [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

FromRalph Sennhauser <ralph.sennhauser@gmail.com>
Date2017-06-09 09:00 +0200
Subject[REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")
Message-ID<tQm3N-6AA-17@gated-at.bofh.it>
Hi Thomas,

Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys
WRT3200ACM), noticed due to missing /dev/input/event0 and the below
dmesg output.

  # dmesg -l 0,1,2,3
  [    2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168)
  [    2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22


After reverting the offending commit all works again.

Ralph

[toc] | [next] | [standalone]


#1662246 — Re: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

FromGregory CLEMENT <gregory.clement@free-electrons.com>
Date2017-06-09 12:20 +0200
SubjectRe: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")
Message-ID<tQpbk-h3-23@gated-at.bofh.it>
In reply to#1661985
Hi Ralph,
 
 On ven., juin 09 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:

> Hi Thomas,
>
> Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
> access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys
> WRT3200ACM), noticed due to missing /dev/input/event0 and the below
> dmesg output.
>
>   # dmesg -l 0,1,2,3
>   [    2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168)
>   [    2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22
>
>
> After reverting the offending commit all works again.

I found the bug and I've just sent a fix for it (use the v2 as the first
version was wrong).

Thanks for the report,

Gregory


>
> Ralph

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web