Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1660831 > unrolled thread

Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node

Started byUlf Hansson <ulf.hansson@linaro.org>
First post2017-06-08 09:30 +0200
Last post2017-06-09 12:50 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-08 09:30 +0200
    Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node Tony Lindgren <tony@atomide.com> - 2017-06-08 10:50 +0200
      Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-09 14:30 +0200
    Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-09 10:10 +0200
      Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node Ulf Hansson <ulf.hansson@linaro.org> - 2017-06-09 12:50 +0200

#1660831 — Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-06-08 09:30 +0200
SubjectRe: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node
Message-ID<tQ03g-1dY-13@gated-at.bofh.it>
On 7 June 2017 at 11:37, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> There are the set of fixes that were sent initially as part
> of [1].
>
> These are mostly fixes w.r.t populating regulators in
> mmc dt node. It was working before because the regulators
> connecting to the IO lines are always on regulators. This will
> break once we add UHS support where voltage has to be changed
> dynamically.
>
> It also includes a patch to replace all vmmc_aux-supply
> with vqmmc-supply (In omap3-overo-base.dtsi remove the existing
> vqmmc-supply and then replace vmmc_aux-supply with vqmmc-supply).
> This will break old dt compatibility but not sure how better
> to handle this.
>
> Performed enumeration testing on dra72-evm-revc, dra72-evm,
> dra7-evm, am572x-evm, am571x-idk, am572x-idk, omap5-evm,
> pandaboard-es, am43xx-evm, am335x-evm, beagleboard etc.,
>
> This is a preparation series for adding UHS mode support in
> the above mentioned platforms.
>
> Changes from v1:
> *) Included a patch to replace deprecated "vmmc_aux" with
>    "vqmmc"
>
> [1] -> https://lkml.org/lkml/2017/5/19/196
>
> Kishon Vijay Abraham I (6):
>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>   ARM: dts: dra72-evm: Add vqmmc supply to mmc1
>   ARM: dts: dra72-evm-revc: Add vqmmc supply to mmc1
>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>     lines
>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>   ARM: dts: omap*: Replace deprecated "vmmc_aux" with "vqmmc"
>
> Ravikumar Kattekola (1):
>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>
> Sekhar Nori (1):
>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>
>  arch/arm/boot/dts/am572x-idk.dts               |  2 +-
>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts  |  2 +-
>  arch/arm/boot/dts/dra7-evm.dts                 | 12 ++++++++--
>  arch/arm/boot/dts/dra7.dtsi                    |  5 +++++
>  arch/arm/boot/dts/dra71-evm.dts                | 16 ++++++++++++-
>  arch/arm/boot/dts/dra72-evm-common.dtsi        |  2 --
>  arch/arm/boot/dts/dra72-evm-revc.dts           | 18 +++++++++++++++
>  arch/arm/boot/dts/dra72-evm-tps65917.dtsi      |  2 +-
>  arch/arm/boot/dts/dra72-evm.dts                | 18 +++++++++++++++
>  arch/arm/boot/dts/omap3-beagle-xm.dts          |  2 +-
>  arch/arm/boot/dts/omap3-beagle.dts             |  2 +-
>  arch/arm/boot/dts/omap3-cm-t3517.dts           |  2 +-
>  arch/arm/boot/dts/omap3-cm-t3730.dts           |  2 +-
>  arch/arm/boot/dts/omap3-devkit8000-common.dtsi |  2 +-
>  arch/arm/boot/dts/omap3-evm-common.dtsi        |  2 +-
>  arch/arm/boot/dts/omap3-n900.dts               |  2 +-
>  arch/arm/boot/dts/omap3-overo-base.dtsi        |  3 +--
>  arch/arm/boot/dts/omap3-tao3530.dtsi           |  2 +-
>  arch/arm/boot/dts/omap3-zoom3.dts              |  2 +-
>  arch/arm/boot/dts/omap3430-sdp.dts             |  2 +-
>  arch/arm/mach-omap2/pdata-quirks.c             | 31 ++++++++++++++++++++++++++
>  include/linux/platform_data/hsmmc-omap.h       |  3 +++
>  22 files changed, 114 insertions(+), 20 deletions(-)
>
> --
> 2.11.0
>

If it helps, I can host a branch with the updates on the omap_hsmmc
driver, such it can be pulled in from arm soc?

I guess you need that as, the DT changes relies on the new vqmmc
binding. Or you thing it doesn't matter, because for the current
changes that regulator is always an always on regulator?

Br
Uffe

[toc] | [next] | [standalone]

#1660949

FromTony Lindgren <tony@atomide.com>
Date2017-06-08 10:50 +0200
Message-ID<tQ1iG-1UD-7@gated-at.bofh.it>
In reply to#1660831
* Ulf Hansson <ulf.hansson@linaro.org> [170608 00:24]:
> If it helps, I can host a branch with the updates on the omap_hsmmc
> driver, such it can be pulled in from arm soc?

Great that works for me. Let's just make sure git bisect
keeps working.

> I guess you need that as, the DT changes relies on the new vqmmc
> binding. Or you thing it doesn't matter, because for the current
> changes that regulator is always an always on regulator?

Or maybe we can just add the new regulator, then do a
follow-up series to remove the old ones?

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1662375

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-09 14:30 +0200
Message-ID<tQrd7-1sb-11@gated-at.bofh.it>
In reply to#1660949
Hi Tony,

On Thursday 08 June 2017 02:16 PM, Tony Lindgren wrote:
> * Ulf Hansson <ulf.hansson@linaro.org> [170608 00:24]:
>> If it helps, I can host a branch with the updates on the omap_hsmmc
>> driver, such it can be pulled in from arm soc?
> 
> Great that works for me. Let's just make sure git bisect
> keeps working.
> 
>> I guess you need that as, the DT changes relies on the new vqmmc
>> binding. Or you thing it doesn't matter, because for the current
>> changes that regulator is always an always on regulator?
> 
> Or maybe we can just add the new regulator, then do a
> follow-up series to remove the old ones?

Since the driver has a fallback mechanism wherein if it's not able to find
vqmmc, it'll fallback to vmmc_aux, I don't think that's required.

Thanks
Kishon

[toc] | [prev] | [next] | [standalone]

#1662075

FromKishon Vijay Abraham I <kishon@ti.com>
Date2017-06-09 10:10 +0200
Message-ID<tQn9w-7uN-25@gated-at.bofh.it>
In reply to#1660831
Hi,

On Thursday 08 June 2017 12:50 PM, Ulf Hansson wrote:
> On 7 June 2017 at 11:37, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> There are the set of fixes that were sent initially as part
>> of [1].
>>
>> These are mostly fixes w.r.t populating regulators in
>> mmc dt node. It was working before because the regulators
>> connecting to the IO lines are always on regulators. This will
>> break once we add UHS support where voltage has to be changed
>> dynamically.
>>
>> It also includes a patch to replace all vmmc_aux-supply
>> with vqmmc-supply (In omap3-overo-base.dtsi remove the existing
>> vqmmc-supply and then replace vmmc_aux-supply with vqmmc-supply).
>> This will break old dt compatibility but not sure how better
>> to handle this.
>>
>> Performed enumeration testing on dra72-evm-revc, dra72-evm,
>> dra7-evm, am572x-evm, am571x-idk, am572x-idk, omap5-evm,
>> pandaboard-es, am43xx-evm, am335x-evm, beagleboard etc.,
>>
>> This is a preparation series for adding UHS mode support in
>> the above mentioned platforms.
>>
>> Changes from v1:
>> *) Included a patch to replace deprecated "vmmc_aux" with
>>    "vqmmc"
>>
>> [1] -> https://lkml.org/lkml/2017/5/19/196
>>
>> Kishon Vijay Abraham I (6):
>>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>>   ARM: dts: dra72-evm: Add vqmmc supply to mmc1
>>   ARM: dts: dra72-evm-revc: Add vqmmc supply to mmc1
>>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>>     lines
>>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>>   ARM: dts: omap*: Replace deprecated "vmmc_aux" with "vqmmc"
>>
>> Ravikumar Kattekola (1):
>>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>>
>> Sekhar Nori (1):
>>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>>
>>  arch/arm/boot/dts/am572x-idk.dts               |  2 +-
>>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts  |  2 +-
>>  arch/arm/boot/dts/dra7-evm.dts                 | 12 ++++++++--
>>  arch/arm/boot/dts/dra7.dtsi                    |  5 +++++
>>  arch/arm/boot/dts/dra71-evm.dts                | 16 ++++++++++++-
>>  arch/arm/boot/dts/dra72-evm-common.dtsi        |  2 --
>>  arch/arm/boot/dts/dra72-evm-revc.dts           | 18 +++++++++++++++
>>  arch/arm/boot/dts/dra72-evm-tps65917.dtsi      |  2 +-
>>  arch/arm/boot/dts/dra72-evm.dts                | 18 +++++++++++++++
>>  arch/arm/boot/dts/omap3-beagle-xm.dts          |  2 +-
>>  arch/arm/boot/dts/omap3-beagle.dts             |  2 +-
>>  arch/arm/boot/dts/omap3-cm-t3517.dts           |  2 +-
>>  arch/arm/boot/dts/omap3-cm-t3730.dts           |  2 +-
>>  arch/arm/boot/dts/omap3-devkit8000-common.dtsi |  2 +-
>>  arch/arm/boot/dts/omap3-evm-common.dtsi        |  2 +-
>>  arch/arm/boot/dts/omap3-n900.dts               |  2 +-
>>  arch/arm/boot/dts/omap3-overo-base.dtsi        |  3 +--
>>  arch/arm/boot/dts/omap3-tao3530.dtsi           |  2 +-
>>  arch/arm/boot/dts/omap3-zoom3.dts              |  2 +-
>>  arch/arm/boot/dts/omap3430-sdp.dts             |  2 +-
>>  arch/arm/mach-omap2/pdata-quirks.c             | 31 ++++++++++++++++++++++++++
>>  include/linux/platform_data/hsmmc-omap.h       |  3 +++
>>  22 files changed, 114 insertions(+), 20 deletions(-)
>>
>> --
>> 2.11.0
>>
> 
> If it helps, I can host a branch with the updates on the omap_hsmmc
> driver, such it can be pulled in from arm soc?
> 
> I guess you need that as, the DT changes relies on the new vqmmc
> binding. Or you thing it doesn't matter, because for the current
> changes that regulator is always an always on regulator?

Since there is fallback mechanism in omap_hsmmc driver (falls back to
vmmc_aux), dt changes shouldn't rely on the omap_hsmmc driver.

However I'll send a fix for omap3-overo-base which used vqmmc incorrectly (that
should be merged before omap_hsmmc driver changes) so that git bisect does not
break.

Thanks
Kishon

[toc] | [prev] | [next] | [standalone]

#1662281

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-06-09 12:50 +0200
Message-ID<tQpEm-qv-25@gated-at.bofh.it>
In reply to#1662075
On 9 June 2017 at 10:05, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> Hi,
>
> On Thursday 08 June 2017 12:50 PM, Ulf Hansson wrote:
>> On 7 June 2017 at 11:37, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> There are the set of fixes that were sent initially as part
>>> of [1].
>>>
>>> These are mostly fixes w.r.t populating regulators in
>>> mmc dt node. It was working before because the regulators
>>> connecting to the IO lines are always on regulators. This will
>>> break once we add UHS support where voltage has to be changed
>>> dynamically.
>>>
>>> It also includes a patch to replace all vmmc_aux-supply
>>> with vqmmc-supply (In omap3-overo-base.dtsi remove the existing
>>> vqmmc-supply and then replace vmmc_aux-supply with vqmmc-supply).
>>> This will break old dt compatibility but not sure how better
>>> to handle this.
>>>
>>> Performed enumeration testing on dra72-evm-revc, dra72-evm,
>>> dra7-evm, am572x-evm, am571x-idk, am572x-idk, omap5-evm,
>>> pandaboard-es, am43xx-evm, am335x-evm, beagleboard etc.,
>>>
>>> This is a preparation series for adding UHS mode support in
>>> the above mentioned platforms.
>>>
>>> Changes from v1:
>>> *) Included a patch to replace deprecated "vmmc_aux" with
>>>    "vqmmc"
>>>
>>> [1] -> https://lkml.org/lkml/2017/5/19/196
>>>
>>> Kishon Vijay Abraham I (6):
>>>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>>>   ARM: dts: dra72-evm: Add vqmmc supply to mmc1
>>>   ARM: dts: dra72-evm-revc: Add vqmmc supply to mmc1
>>>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>>>     lines
>>>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>>>   ARM: dts: omap*: Replace deprecated "vmmc_aux" with "vqmmc"
>>>
>>> Ravikumar Kattekola (1):
>>>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>>>
>>> Sekhar Nori (1):
>>>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>>>
>>>  arch/arm/boot/dts/am572x-idk.dts               |  2 +-
>>>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts  |  2 +-
>>>  arch/arm/boot/dts/dra7-evm.dts                 | 12 ++++++++--
>>>  arch/arm/boot/dts/dra7.dtsi                    |  5 +++++
>>>  arch/arm/boot/dts/dra71-evm.dts                | 16 ++++++++++++-
>>>  arch/arm/boot/dts/dra72-evm-common.dtsi        |  2 --
>>>  arch/arm/boot/dts/dra72-evm-revc.dts           | 18 +++++++++++++++
>>>  arch/arm/boot/dts/dra72-evm-tps65917.dtsi      |  2 +-
>>>  arch/arm/boot/dts/dra72-evm.dts                | 18 +++++++++++++++
>>>  arch/arm/boot/dts/omap3-beagle-xm.dts          |  2 +-
>>>  arch/arm/boot/dts/omap3-beagle.dts             |  2 +-
>>>  arch/arm/boot/dts/omap3-cm-t3517.dts           |  2 +-
>>>  arch/arm/boot/dts/omap3-cm-t3730.dts           |  2 +-
>>>  arch/arm/boot/dts/omap3-devkit8000-common.dtsi |  2 +-
>>>  arch/arm/boot/dts/omap3-evm-common.dtsi        |  2 +-
>>>  arch/arm/boot/dts/omap3-n900.dts               |  2 +-
>>>  arch/arm/boot/dts/omap3-overo-base.dtsi        |  3 +--
>>>  arch/arm/boot/dts/omap3-tao3530.dtsi           |  2 +-
>>>  arch/arm/boot/dts/omap3-zoom3.dts              |  2 +-
>>>  arch/arm/boot/dts/omap3430-sdp.dts             |  2 +-
>>>  arch/arm/mach-omap2/pdata-quirks.c             | 31 ++++++++++++++++++++++++++
>>>  include/linux/platform_data/hsmmc-omap.h       |  3 +++
>>>  22 files changed, 114 insertions(+), 20 deletions(-)
>>>
>>> --
>>> 2.11.0
>>>
>>
>> If it helps, I can host a branch with the updates on the omap_hsmmc
>> driver, such it can be pulled in from arm soc?
>>
>> I guess you need that as, the DT changes relies on the new vqmmc
>> binding. Or you thing it doesn't matter, because for the current
>> changes that regulator is always an always on regulator?
>
> Since there is fallback mechanism in omap_hsmmc driver (falls back to
> vmmc_aux), dt changes shouldn't rely on the omap_hsmmc driver.

Ahh, I get it.

So no immutable branch needed, although only the DTS changes is need
for me below.

>
> However I'll send a fix for omap3-overo-base which used vqmmc incorrectly (that
> should be merged before omap_hsmmc driver changes) so that git bisect does not
> break.

Great! Thanks for sorting this out!

>
> Thanks
> Kishon

Kind regards
Uffe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web