Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1661854 > unrolled thread

[PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long

Started byElias Carter <edcarter@ualberta.ca>
First post2017-06-09 03:40 +0200
Last post2017-06-09 09:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long Elias Carter <edcarter@ualberta.ca> - 2017-06-09 03:40 +0200
    Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80  characters long Greg KH <gregkh@linuxfoundation.org> - 2017-06-09 07:50 +0200
      Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80  characters long Elias Carter <edcarter@ualberta.ca> - 2017-06-09 08:30 +0200
        Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80  characters long Greg KH <gregkh@linuxfoundation.org> - 2017-06-09 09:00 +0200

#1661854 — [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long

FromElias Carter <edcarter@ualberta.ca>
Date2017-06-09 03:40 +0200
Subject[PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long
Message-ID<tQh45-3sH-5@gated-at.bofh.it>
From: edcarter <edcarter@ualberta.ca>

Fixed a coding style issue where a line was longer than 80 characters.

Signed-off-by: Elias Carter <edcarter@ualberta.ca>
---
 drivers/staging/wlan-ng/cfg80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 178f6f5..e82043e 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -692,7 +692,8 @@ static const struct cfg80211_ops prism2_usb_cfg_ops = {
 };
 
 /* Functions to create/free wiphy interface */
-static struct wiphy *wlan_create_wiphy(struct device *dev, struct wlandevice *wlandev)
+static struct wiphy *wlan_create_wiphy(struct device *dev,
+				       struct wlandevice *wlandev)
 {
 	struct wiphy *wiphy;
 	struct prism2_wiphy_private *priv;
-- 
2.7.4

[toc] | [next] | [standalone]


#1661938 — Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-09 07:50 +0200
SubjectRe: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long
Message-ID<tQkY1-5Xn-1@gated-at.bofh.it>
In reply to#1661854
On Thu, Jun 08, 2017 at 06:38:30PM -0700, Elias Carter wrote:
> From: edcarter <edcarter@ualberta.ca>
> 
> Fixed a coding style issue where a line was longer than 80 characters.
> 
> Signed-off-by: Elias Carter <edcarter@ualberta.ca>

Your from and signed-off-by names have to match :(

[toc] | [prev] | [next] | [standalone]


#1661967 — Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long

FromElias Carter <edcarter@ualberta.ca>
Date2017-06-09 08:30 +0200
SubjectRe: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long
Message-ID<tQlAK-6ri-19@gated-at.bofh.it>
In reply to#1661938
On Fri, Jun 09, 2017 at 07:41:12AM +0200, Greg KH wrote:
> On Thu, Jun 08, 2017 at 06:38:30PM -0700, Elias Carter wrote:
> > From: edcarter <edcarter@ualberta.ca>
> > 
> > Fixed a coding style issue where a line was longer than 80 characters.
> > 
> > Signed-off-by: Elias Carter <edcarter@ualberta.ca>
> 
> Your from and signed-off-by names have to match :(

Hi Greg, thanks for the feedback.

I fixed the issue but I was wondering if I should include the patch in a
reply to this email or resend a new patch?

I am just trying to find my way around the development process.

[toc] | [prev] | [next] | [standalone]


#1661982 — Re: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-06-09 09:00 +0200
SubjectRe: [PATCH] staging: wlan-ng: cfg80211.c: fixed a line over 80 characters long
Message-ID<tQm3M-6AA-13@gated-at.bofh.it>
In reply to#1661967
On Thu, Jun 08, 2017 at 11:25:55PM -0700, Elias Carter wrote:
> On Fri, Jun 09, 2017 at 07:41:12AM +0200, Greg KH wrote:
> > On Thu, Jun 08, 2017 at 06:38:30PM -0700, Elias Carter wrote:
> > > From: edcarter <edcarter@ualberta.ca>
> > > 
> > > Fixed a coding style issue where a line was longer than 80 characters.
> > > 
> > > Signed-off-by: Elias Carter <edcarter@ualberta.ca>
> > 
> > Your from and signed-off-by names have to match :(
> 
> Hi Greg, thanks for the feedback.
> 
> I fixed the issue but I was wondering if I should include the patch in a
> reply to this email or resend a new patch?

Totally new patch.

> I am just trying to find my way around the development process.

You did read Documenation/development_process/ right?

Also, please use scripts/get_maintainer.pl to determine who else to cc:
patches on.

good luck!

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web