Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1661894 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-06-09 05:30 +0200 |
| Last post | 2017-06-13 09:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] wireless: wlcore: spi: remove unnecessary variable "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-09 05:30 +0200
Re: [PATCH] wireless: wlcore: spi: remove unnecessary variable Kalle Valo <kvalo@codeaurora.org> - 2017-06-09 10:20 +0200
Re: wlcore: spi: remove unnecessary variable Kalle Valo <kvalo@codeaurora.org> - 2017-06-13 09:10 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-09 05:30 +0200 |
| Subject | [PATCH] wireless: wlcore: spi: remove unnecessary variable |
| Message-ID | <tQiMx-4Eh-9@gated-at.bofh.it> |
Remove unnecessary variable and refactor the code.
Addresses-Coverity-ID: 1365000
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/wireless/ti/wlcore/spi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index fa3547e..d2d899a 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -366,17 +366,14 @@ static int __wl12xx_spi_raw_write(struct device *child, int addr,
static int __must_check wl12xx_spi_raw_write(struct device *child, int addr,
void *buf, size_t len, bool fixed)
{
- int ret;
-
/* The ELP wakeup write may fail the first time due to internal
* hardware latency. It is safer to send the wakeup command twice to
* avoid unexpected failures.
*/
if (addr == HW_ACCESS_ELP_CTRL_REG)
- ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
- ret = __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
+ __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
- return ret;
+ return __wl12xx_spi_raw_write(child, addr, buf, len, fixed);
}
/**
--
2.5.0
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-06-09 10:20 +0200 |
| Message-ID | <tQnjc-7y0-3@gated-at.bofh.it> |
| In reply to | #1661894 |
"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> I'll remove "wireless:" from the prefix. -- Kalle Valo
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-06-13 09:10 +0200 |
| Subject | Re: wlcore: spi: remove unnecessary variable |
| Message-ID | <tRO7E-4US-25@gated-at.bofh.it> |
| In reply to | #1661894 |
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Patch applied to wireless-drivers-next.git, thanks. c48c281e7236 wlcore: spi: remove unnecessary variable -- https://patchwork.kernel.org/patch/9777073/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web