Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1660896 > unrolled thread
| Started by | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| First post | 2017-06-08 10:00 +0200 |
| Last post | 2017-06-09 03:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller Andrew Jeffery <andrew@aj.id.au> - 2017-06-08 10:00 +0200
Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller Guenter Roeck <linux@roeck-us.net> - 2017-06-08 14:40 +0200
Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller Andrew Jeffery <andrew@aj.id.au> - 2017-06-09 03:00 +0200
| From | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| Date | 2017-06-08 10:00 +0200 |
| Subject | Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller |
| Message-ID | <tQ0wi-1oo-39@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote: > On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: > > Add a basic driver for the MAX31785, focusing on the fan control > > features but ignoring the temperature and voltage monitoring > > features of the device. > > > > This driver supports all fan control modes and tachometer / PWM > > readback where applicable. > > > > > > Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > --- > > Hello, > > > > This is a rework of Timothy Pearson's original patch: > > > > https://www.mail-archive.com/linux-hwmon@vger.kernel.org/msg00868.html > > > > I've labelled it as v3 to differentiate from Timothy's postings. > > > > The original thread had some discussion about the MAX31785 being a PMBus device > > and that it should thus be a PMBus driver. The implementation still makes use > > After thinking about it, that is what it should be. If I accept it as non-PMBus > driver, it will be all but impossible to convert it to a PMBus driver later on, > and that just doesn't make any sense. Hopefully not being too ignorant here, but can you expand on why it would be all but impossible to convert? > > With no one interested in writing that driver, I'll try to give it some more > priority myself. I do have an evaluation board somewhere, which should help. > > Note that the second fan reading should be implemented as just that, not with > a non-standard attribute. Agreed. Andrew
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-06-08 14:40 +0200 |
| Message-ID | <tQ4Th-4hK-45@gated-at.bofh.it> |
| In reply to | #1660896 |
On 06/08/2017 12:53 AM, Andrew Jeffery wrote: > On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote: >> On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: >>> Add a basic driver for the MAX31785, focusing on the fan control >>> features but ignoring the temperature and voltage monitoring >>> features of the device. >>> >>> This driver supports all fan control modes and tachometer / PWM >>> readback where applicable. >>> >>>>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> >>>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> >>> --- >>> Hello, >>> >>> This is a rework of Timothy Pearson's original patch: >>> >>> https://www.mail-archive.com/linux-hwmon@vger.kernel.org/msg00868.html >>> >>> I've labelled it as v3 to differentiate from Timothy's postings. >>> >>> The original thread had some discussion about the MAX31785 being a PMBus device >>> and that it should thus be a PMBus driver. The implementation still makes use >> >> After thinking about it, that is what it should be. If I accept it as non-PMBus >> driver, it will be all but impossible to convert it to a PMBus driver later on, >> and that just doesn't make any sense. > > Hopefully not being too ignorant here, but can you expand on why it > would be all but impossible to convert? > I've got a lot of noise recently just for converting a driver from the old to the new API (which changes the attribute location). Changing the driver from non-PMBus to PMBus would very quite likely change some attributes as well. Besides that, I think it is a bad idea to bypass an infrastructure just because it may require a few tweaks. That generates a bad precedent, and people _would_ use that to argue that the next PMBus chip driver should not use the infrastructure either. Guenter >> >> With no one interested in writing that driver, I'll try to give it some more >> priority myself. I do have an evaluation board somewhere, which should help. >> >> Note that the second fan reading should be implemented as just that, not with >> a non-standard attribute. > > Agreed. > > Andrew >
[toc] | [prev] | [next] | [standalone]
| From | Andrew Jeffery <andrew@aj.id.au> |
|---|---|
| Date | 2017-06-09 03:00 +0200 |
| Message-ID | <tQgrn-2Z5-7@gated-at.bofh.it> |
| In reply to | #1661132 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, 2017-06-08 at 05:37 -0700, Guenter Roeck wrote: > On 06/08/2017 12:53 AM, Andrew Jeffery wrote: > > On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote: > > > On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: > > > > Add a basic driver for the MAX31785, focusing on the fan control > > > > features but ignoring the temperature and voltage monitoring > > > > features of the device. > > > > > > > > This driver supports all fan control modes and tachometer / PWM > > > > readback where applicable. > > > > > > > > > > Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > > > > > --- > > > > Hello, > > > > > > > > This is a rework of Timothy Pearson's original patch: > > > > > > > > https://www.mail-archive.com/linux-hwmon@vger.kernel.org/msg00868.html > > > > > > > > I've labelled it as v3 to differentiate from Timothy's postings. > > > > > > > > The original thread had some discussion about the MAX31785 being a PMBus device > > > > and that it should thus be a PMBus driver. The implementation still makes use > > > > > > After thinking about it, that is what it should be. If I accept it as non-PMBus > > > driver, it will be all but impossible to convert it to a PMBus driver later on, > > > and that just doesn't make any sense. > > > > Hopefully not being too ignorant here, but can you expand on why it > > would be all but impossible to convert? > > > > I've got a lot of noise recently just for converting a driver from the old to the > new API (which changes the attribute location). Changing the driver from non-PMBus > to PMBus would very quite likely change some attributes as well. Okay. > > Besides that, I think it is a bad idea to bypass an infrastructure just because > it may require a few tweaks. That generates a bad precedent, and people _would_ > use that to argue that the next PMBus chip driver should not use the infrastructure > either. I understand not wanting to set a precedent. Thanks for your response. Andrew > > Guenter > > > > > > > With no one interested in writing that driver, I'll try to give it some more > > > priority myself. I do have an evaluation board somewhere, which should help. > > > > > > Note that the second fan reading should be implemented as just that, not with > > > a non-standard attribute. > > > > Agreed. > > > > Andrew > > > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web