Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1661623 > unrolled thread

[PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC Dave Hansen <dave.hansen@linux.intel.com> - 2017-06-08 21:50 +0200
    RE: [PATCH] x86, sched: allow topolgies where NUMA nodes share an  LLC "Luck, Tony" <tony.luck@intel.com> - 2017-06-08 22:10 +0200
      Re: [PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC Peter Zijlstra <peterz@infradead.org> - 2017-06-08 22:30 +0200
    Re: [PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC Peter Zijlstra <peterz@infradead.org> - 2017-06-08 22:10 +0200

#1661623 — [PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC

From: Dave Hansen <dave.hansen@linux.intel.com>

Our SMP boot code has a series of assumptions about what NUMA
nodes are that are enforced via topology_sane().  Once upon a
time, we verified that a CPU package only contained a single node
(fixed in cebf15eb0).  Today, we verify that SMT siblings and
LLCs do not span nodes.

The SMT siblings assumption is safe, but the LLC is violated on
current hardware.

Remove the "sanity" check on LLC spanning NUMA nodes.  Also make
sure to set 'x86_has_numa_in_package = true' which ensures that
we use the x86_numa_in_package_topology[].  The default topology
layers NUMA "outside" of the cache, which is wrong when the cache
spans multiple nodes.

This fixes the warnings, but it does theoretically throw away the
LLC from being consulted in scheduling decisions, if the LLC is
shared at a boundary that is not also a NUMA node.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Luck, Tony <tony.luck@intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: David Rientjes <rientjes@google.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: brice.goglin@gmail.com
Cc: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
---

 b/arch/x86/kernel/smpboot.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff -puN arch/x86/kernel/smpboot.c~x86-numa-nodes-share-llc arch/x86/kernel/smpboot.c
--- a/arch/x86/kernel/smpboot.c~x86-numa-nodes-share-llc	2017-06-01 14:46:40.562159566 -0700
+++ b/arch/x86/kernel/smpboot.c	2017-06-01 15:01:43.994157313 -0700
@@ -460,7 +460,7 @@ static bool match_llc(struct cpuinfo_x86
 
 	if (per_cpu(cpu_llc_id, cpu1) != BAD_APICID &&
 	    per_cpu(cpu_llc_id, cpu1) == per_cpu(cpu_llc_id, cpu2))
-		return topology_sane(c, o, "llc");
+		return true;
 
 	return false;
 }
@@ -520,7 +520,8 @@ static struct sched_domain_topology_leve
 
 /*
  * Set if a package/die has multiple NUMA nodes inside.
- * AMD Magny-Cours and Intel Cluster-on-Die have this.
+ * AMD Magny-Cours, Intel Cluster-on-Die, and Intel
+ * Sub-NUMA Clustering have this.
  */
 static bool x86_has_numa_in_package;
 
@@ -548,9 +549,13 @@ void set_cpu_sibling_map(int cpu)
 		if ((i == cpu) || (has_smt && match_smt(c, o)))
 			link_mask(topology_sibling_cpumask, cpu, i);
 
-		if ((i == cpu) || (has_mp && match_llc(c, o)))
-			link_mask(cpu_llc_shared_mask, cpu, i);
-
+		if ((i == cpu) || (has_mp && match_llc(c, o))) {
+			/* LLC may be shared across NUMA nodes */
+			if (topology_same_node(c, o))
+				link_mask(cpu_llc_shared_mask, cpu, i);
+			else
+				x86_has_numa_in_package = true;
+		}
 	}
 
 	/*
_

[toc] | [next] | [standalone]

#1661633 — RE: [PATCH] x86, sched: allow topolgies where NUMA nodes share an LLC

> What does? That does sound broken. How can a cache domain sanely span
> memory controllers?

Think "cluster on die" with cores on the socket split into two clusters, but still sharing LLC.

-Tony

[toc] | [prev] | [next] | [standalone]

#1661663

On Thu, Jun 08, 2017 at 08:08:31PM +0000, Luck, Tony wrote:
> > What does? That does sound broken. How can a cache domain sanely span
> > memory controllers?
> 
> Think "cluster on die" with cores on the socket split into two clusters, but still sharing LLC.

The thing is, cluster-on-die works with the current code, and therefore
seems to modify the SRAT an CPUID information in a consistent manner.

Which in turn seems to suggest the LLC really is split for
cluster-on-die.

This is something new, and the Changelog is absolute crap for not
explaining _anything_.

So while SRAT seems to invent new nodes, the CPUID topology bits still
describes the full LLC, now shared across nodes.

Is this accurate?, do these nodes, as described by SRAT, actually have a
memory controller each? And is the LLC still fully integrated across the
nodes? If so, we need to go fix the scheduler domain topology to put a
cache domain across nodes (which is going to be painful).

Just making the warning go away and not explaining things sucks.

[toc] | [prev] | [next] | [standalone]

#1661637

On Thu, Jun 08, 2017 at 12:39:28PM -0700, Dave Hansen wrote:
> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> Our SMP boot code has a series of assumptions about what NUMA
> nodes are that are enforced via topology_sane().  Once upon a
> time, we verified that a CPU package only contained a single node
> (fixed in cebf15eb0).  Today, we verify that SMT siblings and
> LLCs do not span nodes.
> 
> The SMT siblings assumption is safe, but the LLC is violated on
> current hardware.

What does? That does sound broken. How can a cache domain sanely span
memory controllers?

This needs far more explanation.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web