Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662925 > unrolled thread

[PATCH] cxgb4: Remove some dead code

Started byChristophe JAILLET <christophe.jaillet@wanadoo.fr>
First post2017-06-10 11:20 +0200
Last post2017-06-10 14:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] cxgb4: Remove some dead code Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-06-10 11:20 +0200
    RE: [PATCH] cxgb4: Remove some dead code "Steve Wise" <swise@opengridcomputing.com> - 2017-06-10 14:50 +0200

#1662925 — [PATCH] cxgb4: Remove some dead code

FromChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Date2017-06-10 11:20 +0200
Subject[PATCH] cxgb4: Remove some dead code
Message-ID<tQKIO-5ca-5@gated-at.bofh.it>
This 'BUG_ON(!ep)' can never trigger because we have:
   if (!ep)
      return 0;
just a few lines above. So it can be removed safely.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/infiniband/hw/cxgb4/cm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 2f1136bf7b1f..815d7dfbdfb1 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2879,7 +2879,6 @@ static int close_con_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
 		return 0;
 
 	pr_debug("%s ep %p tid %u\n", __func__, ep, ep->hwtid);
-	BUG_ON(!ep);
 
 	/* The cm_id may be null if we failed to connect */
 	mutex_lock(&ep->com.mutex);
-- 
2.11.0

[toc] | [next] | [standalone]


#1662947

From"Steve Wise" <swise@opengridcomputing.com>
Date2017-06-10 14:50 +0200
Message-ID<tQO02-75l-7@gated-at.bofh.it>
In reply to#1662925
Acked-by: Steve Wise <swise@opengridcomputing.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web