Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1656299 > unrolled thread

[PATCH v2 0/4] PTP support for macb driver

Started byRafal Ozieblo <rafalo@cadence.com>
First post2017-06-02 16:40 +0200
Last post2017-06-06 22:30 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2 0/4] PTP support for macb driver Rafal Ozieblo <rafalo@cadence.com> - 2017-06-02 16:40 +0200
    [PATCH v2 2/4] net: macb: Add tsu_clk to device tree Rafal Ozieblo <rafalo@cadence.com> - 2017-06-02 16:40 +0200
    Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c Richard Cochran <richardcochran@gmail.com> - 2017-06-06 20:50 +0200
      Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c David Miller <davem@davemloft.net> - 2017-06-06 21:10 +0200
        Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c Richard Cochran <richardcochran@gmail.com> - 2017-06-06 22:30 +0200

#1656299 — [PATCH v2 0/4] PTP support for macb driver

FromRafal Ozieblo <rafalo@cadence.com>
Date2017-06-02 16:40 +0200
Subject[PATCH v2 0/4] PTP support for macb driver
Message-ID<tNVKp-2l4-19@gated-at.bofh.it>
This patch series adds support for PTP synchronization protocol
in Cadence GEM driver based on PHC.

v2 changes:
* removed alarm's support
* removed external time stamp support
* removed PTP event interrupt handling
* removed ptp_hw_support flag
* removed all extra sanity checks
* removed unnecessary #ifdef
* fixed coding style and alligment issues
* renamed macb.c to macb_main.c

Rafal Ozieblo (4):
  net: macb: Add support for PTP timestamps in DMA descriptors
  net: macb: Add tsu_clk to device tree
  net: macb: macb.c changed to macb_main.c
  net: macb: Add hardware PTP support

 Documentation/devicetree/bindings/net/macb.txt |    1 +
 drivers/net/ethernet/cadence/Kconfig           |   10 +-
 drivers/net/ethernet/cadence/Makefile          |    5 +
 drivers/net/ethernet/cadence/macb.c            | 3509 -----------------------
 drivers/net/ethernet/cadence/macb.h            |  158 +-
 drivers/net/ethernet/cadence/macb_main.c       | 3647 ++++++++++++++++++++++++
 drivers/net/ethernet/cadence/macb_ptp.c        |  512 ++++
 7 files changed, 4325 insertions(+), 3517 deletions(-)
 delete mode 100644 drivers/net/ethernet/cadence/macb.c
 create mode 100644 drivers/net/ethernet/cadence/macb_main.c
 create mode 100755 drivers/net/ethernet/cadence/macb_ptp.c

-- 
2.4.5

[toc] | [next] | [standalone]


#1656301 — [PATCH v2 2/4] net: macb: Add tsu_clk to device tree

FromRafal Ozieblo <rafalo@cadence.com>
Date2017-06-02 16:40 +0200
Subject[PATCH v2 2/4] net: macb: Add tsu_clk to device tree
Message-ID<tNVU5-2oY-5@gated-at.bofh.it>
In reply to#1656299
Signed-off-by: Rafal Ozieblo <rafalo@cadence.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/macb.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 1506e94..27966ae 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -22,6 +22,7 @@ Required properties:
 	Required elements: 'pclk', 'hclk'
 	Optional elements: 'tx_clk'
 	Optional elements: 'rx_clk' applies to cdns,zynqmp-gem
+	Optional elements: 'tsu_clk'
 - clocks: Phandles to input clocks.
 
 Optional properties for PHY child node:
-- 
2.4.5

[toc] | [prev] | [next] | [standalone]


#1659053 — Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c

FromRichard Cochran <richardcochran@gmail.com>
Date2017-06-06 20:50 +0200
SubjectRe: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c
Message-ID<tPrId-45h-21@gated-at.bofh.it>
In reply to#1656299
On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote:
>  drivers/net/ethernet/cadence/macb.c      | 3568 ------------------------------
>  drivers/net/ethernet/cadence/macb_main.c | 3568 ++++++++++++++++++++++++++++++

You deleted macb.c, and so ...

> diff --git a/drivers/net/ethernet/cadence/Makefile b/drivers/net/ethernet/cadence/Makefile
> index 4ba7559..31ea6e3 100644
> --- a/drivers/net/ethernet/cadence/Makefile
> +++ b/drivers/net/ethernet/cadence/Makefile
> @@ -1,6 +1,7 @@
>  #
>  # Makefile for the Atmel network device drivers.
>  #
> +macb-y	:= macb_main.o
>  
>  obj-$(CONFIG_MACB) += macb.o

how does this rule make sense any more?

Thanks,
Richard

[toc] | [prev] | [next] | [standalone]


#1659072 — Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c

FromDavid Miller <davem@davemloft.net>
Date2017-06-06 21:10 +0200
SubjectRe: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c
Message-ID<tPs1B-4ry-45@gated-at.bofh.it>
In reply to#1659053
From: Richard Cochran <richardcochran@gmail.com>
Date: Tue, 6 Jun 2017 20:39:33 +0200

> On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote:
>>  drivers/net/ethernet/cadence/macb.c      | 3568 ------------------------------
>>  drivers/net/ethernet/cadence/macb_main.c | 3568 ++++++++++++++++++++++++++++++
> 
> You deleted macb.c, and so ...

Rename macb.c to macb_main.c

>> +macb-y	:= macb_main.o
>>  
>>  obj-$(CONFIG_MACB) += macb.o
> 
> how does this rule make sense any more?

He's adjusting the Makefile so that it build macb_main.c into macb.o

[toc] | [prev] | [next] | [standalone]


#1659175 — Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c

FromRichard Cochran <richardcochran@gmail.com>
Date2017-06-06 22:30 +0200
SubjectRe: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c
Message-ID<tPth0-5bW-7@gated-at.bofh.it>
In reply to#1659072
On Tue, Jun 06, 2017 at 03:00:15PM -0400, David Miller wrote:
> He's adjusting the Makefile so that it build macb_main.c into macb.o

Duh, sorry, brain shutting down...

Thanks,
Richard

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web