Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1659027 > unrolled thread
| Started by | Robert LeBlanc <robert@leblancnet.us> |
|---|---|
| First post | 2017-06-06 20:10 +0200 |
| Last post | 2017-06-07 18:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/7] Enable iSCSI offload drivers to use information from iface. Robert LeBlanc <robert@leblancnet.us> - 2017-06-06 20:10 +0200
Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface. Hannes Reinecke <hare@suse.de> - 2017-06-07 10:10 +0200
Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface. Chris Leech <cleech@redhat.com> - 2017-06-07 18:30 +0200
| From | Robert LeBlanc <robert@leblancnet.us> |
|---|---|
| Date | 2017-06-06 20:10 +0200 |
| Subject | [PATCH 0/7] Enable iSCSI offload drivers to use information from iface. |
| Message-ID | <tPr5v-3PW-11@gated-at.bofh.it> |
This patchset enables iSCSI offload drivers to have access to the iface
information provided by iscsid. This allows users to have more control
of how the driver connects to the iSCSI target. iSER is updated to use
iface.ipaddress to set the source IP address if configured. This allows
iSER to use multiple ports on the same network or in more complicated
routed configurations.
Since there is already a change to the function parameters, dst_addr
is upgraded to sockaddr_storage so that it is more future proof and makes
the size of the struct static and not dependent on checking the SA_FAMILY.
This is dependent on updates to Open-iSCSI.
Robert LeBlanc (7):
scsi/scsi_transport_iscsi: Add iface struct to kernel.
scsi/scsi_transport_iscsi: Update ep_connect to include iface.
ib/iSER: Add binding to source IP address.
scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and
sockaddr_storage.
scsi/bnx2i: Update bnx2i_ep_connect to accept iface and
sockaddr_storage.
scsi/cxgbi: Update cxgbi_ep_connect to accept iface and
sockaddr_storage.
scsi/qla4xxx: Update qla4xxx_ep_connect to accept iface and
sockaddr_storage.
drivers/infiniband/ulp/iser/iscsi_iser.c | 33 +++++++--
drivers/infiniband/ulp/iser/iscsi_iser.h | 4 +-
drivers/infiniband/ulp/iser/iser_initiator.c | 1 +
drivers/infiniband/ulp/iser/iser_memory.c | 1 +
drivers/infiniband/ulp/iser/iser_verbs.c | 8 ++-
drivers/scsi/be2iscsi/be_cmds.c | 1 +
drivers/scsi/be2iscsi/be_iscsi.c | 8 ++-
drivers/scsi/be2iscsi/be_iscsi.h | 5 +-
drivers/scsi/be2iscsi/be_main.c | 1 +
drivers/scsi/be2iscsi/be_mgmt.c | 1 +
drivers/scsi/bnx2i/bnx2i_hwi.c | 1 +
drivers/scsi/bnx2i/bnx2i_iscsi.c | 13 ++--
drivers/scsi/cxgbi/libcxgbi.c | 15 ++--
drivers/scsi/cxgbi/libcxgbi.h | 2 +-
drivers/scsi/qla4xxx/ql4_os.c | 15 ++--
drivers/scsi/scsi_transport_iscsi.c | 9 ++-
include/scsi/scsi_transport_iscsi.h | 100 ++++++++++++++++++++++++++-
17 files changed, 179 insertions(+), 39 deletions(-)
--
2.11.0
[toc] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2017-06-07 10:10 +0200 |
| Subject | Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface. |
| Message-ID | <tPEcp-40W-9@gated-at.bofh.it> |
| In reply to | #1659027 |
On 06/06/2017 08:07 PM, Robert LeBlanc wrote: > This patchset enables iSCSI offload drivers to have access to the iface > information provided by iscsid. This allows users to have more control > of how the driver connects to the iSCSI target. iSER is updated to use > iface.ipaddress to set the source IP address if configured. This allows > iSER to use multiple ports on the same network or in more complicated > routed configurations. > > Since there is already a change to the function parameters, dst_addr > is upgraded to sockaddr_storage so that it is more future proof and makes > the size of the struct static and not dependent on checking the SA_FAMILY. > > This is dependent on updates to Open-iSCSI. > > Robert LeBlanc (7): > scsi/scsi_transport_iscsi: Add iface struct to kernel. > scsi/scsi_transport_iscsi: Update ep_connect to include iface. > ib/iSER: Add binding to source IP address. > scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and > sockaddr_storage. > scsi/bnx2i: Update bnx2i_ep_connect to accept iface and > sockaddr_storage. > scsi/cxgbi: Update cxgbi_ep_connect to accept iface and > sockaddr_storage. > scsi/qla4xxx: Update qla4xxx_ep_connect to accept iface and > sockaddr_storage. > > drivers/infiniband/ulp/iser/iscsi_iser.c | 33 +++++++-- > drivers/infiniband/ulp/iser/iscsi_iser.h | 4 +- > drivers/infiniband/ulp/iser/iser_initiator.c | 1 + > drivers/infiniband/ulp/iser/iser_memory.c | 1 + > drivers/infiniband/ulp/iser/iser_verbs.c | 8 ++- > drivers/scsi/be2iscsi/be_cmds.c | 1 + > drivers/scsi/be2iscsi/be_iscsi.c | 8 ++- > drivers/scsi/be2iscsi/be_iscsi.h | 5 +- > drivers/scsi/be2iscsi/be_main.c | 1 + > drivers/scsi/be2iscsi/be_mgmt.c | 1 + > drivers/scsi/bnx2i/bnx2i_hwi.c | 1 + > drivers/scsi/bnx2i/bnx2i_iscsi.c | 13 ++-- > drivers/scsi/cxgbi/libcxgbi.c | 15 ++-- > drivers/scsi/cxgbi/libcxgbi.h | 2 +- > drivers/scsi/qla4xxx/ql4_os.c | 15 ++-- > drivers/scsi/scsi_transport_iscsi.c | 9 ++- > include/scsi/scsi_transport_iscsi.h | 100 ++++++++++++++++++++++++++- > 17 files changed, 179 insertions(+), 39 deletions(-) > Hmm. That it rather large, just for passing information from userspace into the kernel. What is the actual benefit here? Personally, I would rather see iscsid creating tap interfaces associated with each iSCSI offload interface, and having the kernel accessing the information from _that_. Then each connection would have a network interface attached to it, and could retrieve the information from there. Plus we could use 'normal' userspace tools like 'ip' to configure the iSCSI offload network. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Chris Leech <cleech@redhat.com> |
|---|---|
| Date | 2017-06-07 18:30 +0200 |
| Subject | Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface. |
| Message-ID | <tPM0i-zo-11@gated-at.bofh.it> |
| In reply to | #1659027 |
On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: > This patchset enables iSCSI offload drivers to have access to the iface > information provided by iscsid. This allows users to have more control > of how the driver connects to the iSCSI target. iSER is updated to use > iface.ipaddress to set the source IP address if configured. This allows > iSER to use multiple ports on the same network or in more complicated > routed configurations. > > Since there is already a change to the function parameters, dst_addr > is upgraded to sockaddr_storage so that it is more future proof and makes > the size of the struct static and not dependent on checking the SA_FAMILY. > > This is dependent on updates to Open-iSCSI. Hi Robert, I don't think that passing the iface_rec structure directly from the iscsid internals into a netlink message is a good way to go about this. It's really big, there's an embedded list_head with user address pointers that needs to be left out, and there are 32/64-bit layout differences. Let me take a look at how you're proposing using this info for iSER, if it makes sense I think we should come up with a better designed structure for passing the information. Thanks, Chris > Robert LeBlanc (7): > scsi/scsi_transport_iscsi: Add iface struct to kernel. > scsi/scsi_transport_iscsi: Update ep_connect to include iface. > ib/iSER: Add binding to source IP address. > scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and > sockaddr_storage. > scsi/bnx2i: Update bnx2i_ep_connect to accept iface and > sockaddr_storage. > scsi/cxgbi: Update cxgbi_ep_connect to accept iface and > sockaddr_storage. > scsi/qla4xxx: Update qla4xxx_ep_connect to accept iface and > sockaddr_storage. > > drivers/infiniband/ulp/iser/iscsi_iser.c | 33 +++++++-- > drivers/infiniband/ulp/iser/iscsi_iser.h | 4 +- > drivers/infiniband/ulp/iser/iser_initiator.c | 1 + > drivers/infiniband/ulp/iser/iser_memory.c | 1 + > drivers/infiniband/ulp/iser/iser_verbs.c | 8 ++- > drivers/scsi/be2iscsi/be_cmds.c | 1 + > drivers/scsi/be2iscsi/be_iscsi.c | 8 ++- > drivers/scsi/be2iscsi/be_iscsi.h | 5 +- > drivers/scsi/be2iscsi/be_main.c | 1 + > drivers/scsi/be2iscsi/be_mgmt.c | 1 + > drivers/scsi/bnx2i/bnx2i_hwi.c | 1 + > drivers/scsi/bnx2i/bnx2i_iscsi.c | 13 ++-- > drivers/scsi/cxgbi/libcxgbi.c | 15 ++-- > drivers/scsi/cxgbi/libcxgbi.h | 2 +- > drivers/scsi/qla4xxx/ql4_os.c | 15 ++-- > drivers/scsi/scsi_transport_iscsi.c | 9 ++- > include/scsi/scsi_transport_iscsi.h | 100 ++++++++++++++++++++++++++- > 17 files changed, 179 insertions(+), 39 deletions(-) > > -- > 2.11.0 >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web