Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650356 > unrolled thread

[PATCH V1] regulator: core: Fix voltage change propagations to supply regulators

Back to article view | Back to linux.kernel

Contents

  [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Tirupathi Reddy <tirupath@codeaurora.org> - 2017-05-25 12:10 +0200
    Re: [PATCH V1] regulator: core: Fix voltage change propagations to  supply regulators Tirupathi Reddy T <tirupath@codeaurora.org> - 2017-06-05 12:40 +0200
      Re: [PATCH V1] regulator: core: Fix voltage change propagations to  supply regulators Mark Brown <broonie@kernel.org> - 2017-06-06 17:50 +0200

#1650356 — [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators

Some regulators support get_voltage and some support get_voltage_sel
operations. Do voltage change propagation only when the current
regulator has a minimum dropout voltage specified or if the current
regulator lacks both get_voltage and get_voltage_sel operations.

Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
---
 drivers/regulator/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8..9fecbd4 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
 	if (rdev->supply &&
 	    regulator_ops_is_valid(rdev->supply->rdev,
 				   REGULATOR_CHANGE_VOLTAGE) &&
-	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
+	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
+					   rdev->desc->ops->get_voltage_sel))) {
 		int current_supply_uV;
 		int selector;
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

[toc] | [next] | [standalone]

#1657498 — Re: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators

Mark,

Could you please take a look and provide any feedback.

Thanks
Tirupathi Reddy

On 5/25/2017 3:33 PM, Tirupathi Reddy wrote:
> Some regulators support get_voltage and some support get_voltage_sel
> operations. Do voltage change propagation only when the current
> regulator has a minimum dropout voltage specified or if the current
> regulator lacks both get_voltage and get_voltage_sel operations.
>
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---
>   drivers/regulator/core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c0d9ae8..9fecbd4 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
>   	if (rdev->supply &&
>   	    regulator_ops_is_valid(rdev->supply->rdev,
>   				   REGULATOR_CHANGE_VOLTAGE) &&
> -	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
> +	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
> +					   rdev->desc->ops->get_voltage_sel))) {
>   		int current_supply_uV;
>   		int selector;
>   

[toc] | [prev] | [next] | [standalone]

#1658877 — Re: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jun 05, 2017 at 04:06:12PM +0530, Tirupathi Reddy T wrote:
> Mark,
> 
> Could you please take a look and provide any feedback.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web